[Pulp-dev] Google's Code Reviewer Guide

Tatiana Tereshchenko ttereshc at redhat.com
Wed Oct 2 12:39:29 UTC 2019


Thanks for sharing!

Tanya

On Tue, Oct 1, 2019 at 1:52 PM David Davis <daviddavis at redhat.com> wrote:

> I've been reading through Google's Code Reviewer Guide and I've found it
> rather interesting. While reviewing code may seem pretty basic, I have
> found a couple rather insightful points in their guide. One example is that
> they recommend sharing positive feedback while reviewing code--too often
> reviewers focus on what needs to be fixed in PRs. If you have some time, I
> recommend reading through it.
>
> https://google.github.io/eng-practices/review/reviewer/
>
> By the way, they use a term CL which comes from their use of a
> Perforce-like version control system. They define it here under Terminology:
>
> https://google.github.io/eng-practices/
>
> David
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20191002/cbf1052d/attachment.htm>


More information about the Pulp-dev mailing list