[Pulp-dev] Google's Code Reviewer Guide
bmbouter at redhat.com
Wed Oct 2 12:48:02 UTC 2019
Yes thank you! I read it, and I will strive towards its practices.
On Wed, Oct 2, 2019 at 8:40 AM Tatiana Tereshchenko <ttereshc at redhat.com>
> Thanks for sharing!
> On Tue, Oct 1, 2019 at 1:52 PM David Davis <daviddavis at redhat.com> wrote:
>> I've been reading through Google's Code Reviewer Guide and I've found it
>> rather interesting. While reviewing code may seem pretty basic, I have
>> found a couple rather insightful points in their guide. One example is that
>> they recommend sharing positive feedback while reviewing code--too often
>> reviewers focus on what needs to be fixed in PRs. If you have some time, I
>> recommend reading through it.
>> By the way, they use a term CL which comes from their use of a
>> Perforce-like version control system. They define it here under Terminology:
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
> Pulp-dev mailing list
> Pulp-dev at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pulp-dev