[Pulp-dev] Cherry pick labeling

Tatiana Tereshchenko ttereshc at redhat.com
Wed Mar 18 10:02:31 UTC 2020

I believe it's the responsibility of both the author and the PR reviewer.

If it's a one-time contribution from someone, then the PR reviewer is
likely the one who is aware whether the cherry-pick should be done or not.
However in the majority of cases, we have regular contributors and they are
aware of the process. Depending on the fix, they might be in a better
position to say whether it's worth cherry-picking, if the cherry-pick will
be clean or not.

Alternatively, can we automate it? When PR is open, look at the referred
redmine issue and check its tracker, if it's an "issue", mark PR as the one
to be cherry-picked, so reviewer can unset it if it's undesirable for
whatever reason.


On Tue, Mar 17, 2020 at 9:43 PM David Davis <daviddavis at redhat.com> wrote:

> Today we missed a change that could have maybe have gone out with the 3.2
> release. It stemmed from a lack of clarity around whose responsibility it
> is to label PRs with the cherry pick label. I think the general agreement
> is that it's ultimately the responsibility of the PR reviewer to add this
> label to the PR. I'm interested to see if there are any other thoughts or
> objections. Here is a PR I've opened as a proposal:
> https://github.com/pulp/pulpcore/pull/592
> David
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20200318/bce96f82/attachment.htm>

More information about the Pulp-dev mailing list