[Pulp-dev] Re-enable required status checks

Matthias Dellweg mdellweg at redhat.com
Wed Jan 6 11:12:34 UTC 2021


I noticed this too. Somehow i used the wrong channel to ask about it.
Anyway, i think this is breaking any considerable collaboration approach,
because every single PR must be refreshed immediately before merging. This
will put off external contributors.

On Tue, Jan 5, 2021 at 10:42 PM David Davis <daviddavis at redhat.com> wrote:

> I noticed for the repos that got updated, PRs must now be up to date
> before merging. I think we previously had this disabled but I am guessing
> it got enabled since it's the default when required status checks are
> enabled?
>
> David
>
>
> On Fri, Dec 11, 2020 at 7:26 AM Tanya Tereshchenko <ttereshc at redhat.com>
> wrote:
>
>> FYI, I went through the following repos and enabled required checks
>> (lint, test(pulp), test(docs), and test(s3)) where they were missing, for
>> the master and for the release branches if such rules existed:
>>  - pulpcore
>>  - pulp_file
>>  - pulp_rpm
>>  - pulp_container
>>  - pulp_ansible
>>  - pulp_python
>>  - pulp_deb
>>  - pulp-2to3-migration
>>  - pulp-certguard
>>
>>
>> On Wed, Dec 9, 2020 at 5:35 PM David Davis <daviddavis at redhat.com> wrote:
>>
>>> When we stopped using Travis, I disabled the required status checks in
>>> Github for pull requests. To re-enable these required status checks, visit
>>> the branch protection settings page for your plugin's repo. Configure a
>>> branch protection rule and there should be a setting to require status
>>> checks.
>>>
>>> David
>>> _______________________________________________
>>> Pulp-dev mailing list
>>> Pulp-dev at redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20210106/68fab4d4/attachment.htm>


More information about the Pulp-dev mailing list