[Pulp-dev] pulp_rpm and current backwards-compatibility problems

[Grant Gainey]

On Tue, May 11, 2021 at 1:18 PM Tanya Tereshchenko <ttereshc at redhat.com>
wrote:

> Hi Grant,
>
> Thanks for putting this together.
> It sounds about right, as a general idea of what needs to happen.
>
> I would leave it to a person who performs all the git fu to figure out
> exact commits and details and to the reviewer of all those changes, when PR
> 1984 is ready to be merged and releases can be done.
> To say yes, or no, to the plan would mean to check properly all the
> commits/details and it likely would be more time effective to do it when
> the time comes to perform all those steps.
>

Concur.


> Off the top of my head:
>  - pulp_rpm 3.11 needs to be compatible with pulpcore >=3.7,<3.13 as 3.10
> does.
>  - `re-apply the auto-pub/dist-schema changes` should include a migration
> update to adjust the dependency in it.
>
> David,
> All the rush and hassle is happening because of the changes with
> migrations and compatibility with an older release. Some commits which
> need to be reapplied have migrations.
> Whichever way a person who does it decides to do, the migrations order
> should be the same on 3.11 branch and on the master.
>

I'm going to submit a PR to get pulp_rpm's CI unbroken, that has to happen
before we do anything else. THEN I will respond to final review-comments on
PR 1984. Once that passes, THEN we can talk about what happens next. (That
PR, for example, is affected by the proposed reverts, because its migration
is currently built on-top-of the one(s) being reverted and will need to be
renamed. So we/I probably don't want to merge it, until post-revert, and an
update to match the new State Of The World at that point.)

Anyway, first things first...

G


>
> Tanya
>
> On Tue, May 11, 2021 at 7:02 PM David Davis <daviddavis at redhat.com> wrote:
>
>> What if you create a 3.11 release branch and then revert the commits on
>> the 3.11 branch? That would save you from having to reapply the two
>> commits.
>>
>> You could also pin to pulpcore < 3.12 on the 3.11 branch to get the
>> branch passing while you work on fixing the enqueue problem on master.
>>
>> David
>>
>>
>> On Tue, May 11, 2021 at 11:49 AM Grant Gainey <ggainey at redhat.com> wrote:
>>
>>> Hey folks,
>>>
>>> We've been talking about how we need a pulpcore/3.7-to-3.11-compatible
>>> release of pulp_rpm. The static_context change requires a schema-change,
>>> and it has to be available to katello-3.18 (and hence pulpcore-3.7)
>>>
>>> The static_context change is PR#1984
>>> <https://github.com/pulp/pulp_rpm/pull/1984>
>>>
>>> Right now, pulp-rpm/master has changes that require pulpcore/3.12 or
>>> later. Those changes are:
>>>
>>> d0c9badd Refactor distribution migration 0032
>>> fbaadaca Add support for automatic publishing and distributing
>>>
>>> In addition, pulp_rpm/master is *currently broken* because it still
>>> references the deprecated enqueue_with_reservation(), that just got removed
>>> from pulpcore/master.
>>>
>>> As I understand it, what needs to happen #SOON, is the following:
>>>
>>>    1. revert the two commits above and merge,
>>>    2. get the static_context change updated (since a migration will
>>>    have Left the Building) and get it merged,
>>>    3. merge any other fixes that won't break 3.7-compat [OPTIONAL], and
>>>    THEN
>>>    4. cut 3.11 as compatible with 3.7-thru-3.10 pulpcore
>>>
>>> Once pulp_rpm/3.11 is released, we can then:
>>>
>>>    1. re-apply the auto-pub/dist-schema changes,
>>>    2. fix enqueue-problem,
>>>    3. mark pulp_rpm/master as 3.12+ compat, and finally
>>>    4. release pulp_rpm/3.12 to be ready for pulpcore-3.13
>>>
>>> And this all needs to happen by next week?
>>>
>>> Is there anything I'm missing here?
>>>
>>> G
>>> --
>>> Grant Gainey
>>> Principal Software Engineer, Red Hat System Management Engineering
>>> _______________________________________________
>>> Pulp-dev mailing list
>>> Pulp-dev at redhat.com
>>> https://listman.redhat.com/mailman/listinfo/pulp-dev
>>>
>>

-- 
Grant Gainey
Principal Software Engineer, Red Hat System Management Engineering
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20210511/393e3930/attachment.htm>