<div dir="ltr">I agree that given what we've learned today, we should pull the feature from 2.11 and re-think our options for implementing it.<div><br></div><div>Michael</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 7, 2016 at 1:16 PM, Bihan Zhang <span dir="ltr"><<a href="mailto:bizhang@redhat.com" target="_blank">bizhang@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Our initial assumption of pulp_workers records being cleaned up when pulp_celerybeat is down is false.<div>The pulp_workers clean up [0] is being done in celerybeat [1] and not with a SIGTERM handler. </div><div><br></div><div>What this means is that if `systemctl stop pulp_celerybeat` is ran before `systemctl stop pulp_workers` our current pulp-manage-db logic will erroneously display the user prompt.</div><div> </div><div>Since this is the case I think we should remove the pulp-manage-db running worker detection feature for this release (but keep the celerybeat cleanup) and look into other solutions.</div><div><br></div><div><br></div><div>[0] <a href="https://github.com/pulp/pulp/blob/master/server/pulp/server/async/worker_watcher.py#L85-L105" target="_blank">https://github.com/pulp/<wbr>pulp/blob/master/server/pulp/<wbr>server/async/worker_watcher.<wbr>py#L85-L105</a></div><div>[1] <a href="https://github.com/pulp/pulp/blob/master/server/pulp/server/async/scheduler.py#L75" target="_blank">https://github.com/pulp/<wbr>pulp/blob/master/server/pulp/<wbr>server/async/scheduler.py#L75</a></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 7, 2016 at 11:20 AM, Brian Bouterse <span dir="ltr"><<a href="mailto:bbouters@redhat.com" target="_blank">bbouters@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>+1 to reopening 2468 and excluding pulp_celerybeat records from the check, and holding 2.11 until this is resolved<br><br></div><div>Note that ^ would allow us to remove the known issues problem from the release notes which should also be done[0]<br></div><div><br></div>+1 to removing the y/N interactive prompt which would also allow us to close this PR [1].<br><br></div>Also, we should close 2472 as NOTABUG or WORKSFORME as I commented on here [2].<br><div><br>[0]: <a href="https://github.com/pulp/pulp/pull/2878/files#diff-6852a97801e832e280bae8ad6507338aR34" target="_blank">https://github.com/pulp/pulp/p<wbr>ull/2878/files#diff-6852a97801<wbr>e832e280bae8ad6507338aR34</a><br>[1]: <a href="https://github.com/pulp/pulp/pull/2874" target="_blank">https://github.com/pulp/pulp/p<wbr>ull/2874</a><br>[2]: <a href="https://pulp.plan.io/issues/2472#note-8" target="_blank">https://pulp.plan.io/issues/24<wbr>72#note-8</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_7824438329025401790h5">On Wed, Dec 7, 2016 at 10:02 AM, Michael Hrivnak <span dir="ltr"><<a href="mailto:mhrivnak@redhat.com" target="_blank">mhrivnak@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_7824438329025401790h5"><div dir="ltr">We've re-opened issue #2468, and Bihan is going to make the PR that implements this change. If there are any additional questions or concerns, please bring them up ASAP.<div><br></div><div><a href="https://pulp.plan.io/issues/2468" target="_blank">https://pulp.plan.io/issues/24<wbr>68</a><br></div><div><br></div><div>Thanks!</div><span class="m_7824438329025401790m_3879918569963028826HOEnZb"><font color="#888888"><div>Michael</div></font></span></div><div class="m_7824438329025401790m_3879918569963028826HOEnZb"><div class="m_7824438329025401790m_3879918569963028826h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 7, 2016 at 9:51 AM, Sean Myers <span dir="ltr"><<a href="mailto:sean.myers@redhat.com" target="_blank">sean.myers@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 12/07/2016 08:59 AM, Bihan Zhang wrote:<br>
> +1 excluding pulp_celerybeat<br>
><br>
> Also since we have the --ignore-running-workers flag and are ignoring<br>
> celerybeat I would like to propose we stop prompting the user to continue<br>
> and instead just display an error message when we detect running workers:<br>
> 'Migration halted because there are still running workers, please stop all<br>
> workers before re-running this command. If you believe this message was<br>
> given in error please re-run the command with the --ignore-running-workers<br>
> flag'<br>
<br>
</span>I think doing what's proposed would fix #2472. Add that to the fixes<br>
from #2768 and #2769 and this should be good to ship another RC.<br>
<br>
</blockquote></div><br></div>
</div></div><br></div></div><span>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br>
<br></span></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>