<div dir="ltr"><div>It sounded like from the discussion on that issue that the translation would likely happen before so it's unlikely we'd run into the exact usecase that throws the error.</div><div><br></div><div>Still, definitely need to be careful where we use them and not forget that it won't work with gettext.</div><div><br></div><div>--Dana<br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>
<p style="font-weight:bold;margin:0;padding:0;font-size:14px;text-transform:uppercase;margin-bottom:0"><span>Dana</span> <span>Walker</span></p>
<p style="font-weight:normal;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>Associate Software Engineer</span><span style="font-weight:normal;color:#aaa;margin:0"></span></p>
<p style="font-weight:normal;margin:0;font-size:10px;color:#999"><a style="color:#0088ce;font-size:10px;margin:0;text-decoration:none;font-family:'overpass',sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span><br><br></span></a></p>
<table border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"> <img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a> </td>
</tr></tbody></table>
</div></div></div></div>
<br><div class="gmail_quote">On Fri, Oct 5, 2018 at 11:29 AM, David Davis <span dir="ltr"><<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr">I’d love to use f-strings as they seem to offer a speed improvement and are IMO more readable. However, I did some research and it looks like we can’t use them with gettext:<br><div><br></div><div><a href="https://bugs.python.org/issue33189" target="_blank">https://bugs.python.org/<wbr>issue33189</a></div><div><br></div><div>Which is rather unfortunate. I suppose in those rare cases where we use an interpolated string that doesn’t require translation, we could use f-strings.<br clear="all"><div><div dir="ltr" class="m_5934012793678109164gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div><br></div></div></div></div><br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Fri, Oct 5, 2018 at 11:15 AM Kersom <<a href="mailto:kersom@redhat.com" target="_blank">kersom@redhat.com</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div dir="ltr"><div>Since support for Python 3.5 was dropped. Perhaps we
could evaluate Pulp 3 adopt the new features supported by Python3.6 only, such as f'strings.[0]</div><div><br></div><div></div><div>Just a suggestion.</div><div><br></div><div>[0] <a href="https://docs.python.org/3/reference/lexical_analysis.html#f-strings" target="_blank">https://docs.python.org/3/<wbr>reference/lexical_analysis.<wbr>html#f-strings</a><br></div><div><br></div></div></div></div></div>
______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
</blockquote></div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>