[Pulp-list] Thoughts regarding #214

[Jeff Ortel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Team,

When working on issue #214, I'm finding the following:

1. The last_published property on a Distributor document is updated
   even if the publish fails.

2. The last_published is stored as iso8601 string instead of an ISODate.

To support #214, I think both of these things need to be changed.  The
last_published needs to be migrated to be an ISODate in the DB.  And,
the last_published needs to only be updated on success.

I can maintain API backwards compatibility by serializing the
last_published property as an iso8601 string.  But, the suggested change
of only updating it on success would represent a slight change in the
meaning.  Though, I'd be surprised if it's used for anything other than
display.

Questions:

1. Would this be acceptable in a Y release or does this need to wait for
the next major release?

2. Would it break anything?

Thoughts?


- -jeff


[1] https://pulp.plan.io/issues/214
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVP6adAAoJEM9lW7UwFwZXNKgP/ip4kfNIpbNNzkaPYgrX7Y1M
xE4ZwY6uzAsltDbTz8La61wwDhPQkthIr5M3EjqHlFpjrz0PnYC7Z+MDSR8QVvxr
bveeM6gzqwFCnyGzNsFBvYu8846w8Mc6xicxIYoaYXs9MYwa5IZw5PalHl+b5PFH
0AnccTN5EDbkzGijpHjxxKKa7Qq9oEEbll4tkrrYT4I3eGq1EMghQz7jPyD9OJhD
4DrPomYRzmCBQJqdj1muETukcBc6uLtWKI7yPfCFfkNoXuC5Rx+jGaXnLDxeF+l6
hxwrnFXn3hwFCBNVHRLtcffkk6qMf74rI1sHJEVB+i04FPACoKIsuM26fu9wWlxa
ySw6ksQCAtP4DhKhVnqK0frXElG6w3sAiUs1zybgxgp9ZsCLXt9h8WPC7h9G/iBW
j5kSgbci2BT9zVhw2uSCYTHqOFRyVmnRy7ylxG8060g9DStEis1iH3tDWnxg+2yh
ogl2/M+O1l744nZrOEo2vVCJKI93C2J2XOylfOqCpdpfQCRePFYQ/i18jdQZtIPI
fVpw0lO1rZhuMAAex6pjF+w5FMfajHEkKFdF3aGUQ14IGoGIY3tNxFKu9q9Nne0T
ea9Bl42rnyHHfQwuRAiLP1wDUp6PJbd+uSrHbdbOPyedkxxSCaGxSRA2+nAxOSK/
RXySe61s7PwNd0LN8ZiW
=3poL
-----END PGP SIGNATURE-----