[Pulp-list] Thoughts regarding #214

[Jeff Ortel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 04/28/2015 12:17 PM, Dennis Gregorovic wrote:
> 
> 
> On 04/28/2015 11:26 AM, Jeff Ortel wrote:
>> Team,
> 
>> When working on issue #214, I'm finding the following:
> 
>> 1. The last_published property on a Distributor document is
>> updated even if the publish fails.
> 
>> 2. The last_published is stored as iso8601 string instead of an
>> ISODate.
> 
>> To support #214, I think both of these things need to be changed.
>> The last_published needs to be migrated to be an ISODate in the
>> DB.  And, the last_published needs to only be updated on
>> success.
> 
>> I can maintain API backwards compatibility by serializing the 
>> last_published property as an iso8601 string.  But, the suggested
>> change of only updating it on success would represent a slight
>> change in the meaning.  Though, I'd be surprised if it's used for
>> anything other than display.
> 
>> Questions:
> 
>> 1. Would this be acceptable in a Y release or does this need to
>> wait for the next major release?
> 
>> 2. Would it break anything?
> 
>> Thoughts?
> 
> 
>> -jeff
> 
> 
>> [1] https://pulp.plan.io/issues/214
> 
>> _______________________________________________ Pulp-list mailing
>> list Pulp-list at redhat.com 
>> https://www.redhat.com/mailman/listinfo/pulp-list
> 
> 
> I wonder if the repo_publish_results collection would be a better
> data source for this API.  I don't think it existed when the RFE
> was originally filed.

Good suggestion.  Thanks.  I'll have a look.

> 
> -- Dennis
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVP8L1AAoJEM9lW7UwFwZXahMQAJ16gb/023rAH0PjCbjYKZam
nnix54LtUO/VS2Ax6unP1Smogh8lwFaOyKmwFnwdQ0bwUU6Ck4I97/3XC2v5DRAo
lh4V7PPn2X1vDWNiK9sOIGanZpydcZeEsH+IMXDEMJv3QEuylhbasbMcJhB4Y2Nw
PBTkMWXjvP5NouCbNG3jxde5/DWp5x5reR4kPw+p+GYskQ5fvqdE0CnK9aAf+kWI
liy7KBAgBYTB60qqKeJLKOoyUxND5UVuX3J3Aq88P5VdbWxnzNSnM95gUVlEuQQh
K7aozT8/ZieMoTPmOvIL03vQza+Jwi0E2o5aoRU2acL6IaUOXhi2eNmHspSiknnI
K5kJbNnnmkWOMP5/YayP2k2/Pfgzn+ssXwmXK35E/jMWT/JxcYI6Y2AfpV+jm0GC
xdN9heit8FJJ0FlWjej4V8d+Cgn/e5hXrAyidXCsd2TUBt846cfVaCtNOYwf6sKH
xfXQkhxMImcFW9fhzmr4DBuKB+G2baLK3k6kZemNSiMyjJKJ4g5q8W9F+KzhBPmv
x1m180MyVCR3a5pE9gW3SS/6Jvz750Yx4cnk/+ZOedlc3L4TJJDMnnShxo4UAI4E
ChTT9cPVj/YrDHQoFlF7lJwDtufBAGxI1i97JDsbqbX2dugX3KvmN3OI4XhBniJo
fKrEpupKBn6Z/zBDsivi
=Rl0t
-----END PGP SIGNATURE-----