[Pulp-list] [devel] import ordering for pulp code

Chris Duryee cduryee at redhat.com
Wed Feb 25 15:37:36 UTC 2015


There is a library that adds import order checking to flake8[1]. Is this
something we can enable for Pulp platform? This would let us look at one
less thing during PR review.

The linter ships with two styles, one written by the authors of the
module and the other is the Google code style. Examples are at [2] and
[3]. I'd be OK personally with either style.

If we wanted to use this linter, we may need to set it up but not
include it in run-tests.py until all of the imports are fixed. Currently
there are about 350 errors.


[1] https://github.com/public/flake8-import-order
[2]
https://github.com/public/flake8-import-order/blob/master/tests/test_cases/complete.py
[3]
https://github.com/public/flake8-import-order/blob/master/tests/test_cases/complete_google.py




More information about the Pulp-list mailing list