[Pulp-list] [devel] mongoengine ContentUnit changes on master

Brian Bouterse bbouters at redhat.com
Fri Oct 30 15:05:08 UTC 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

A change [0] has been merged to master which may require updates from
plugin authors. Specifically, if you've written a plugin unit which
subclasses the mongoengine based ContentUnit, two fields are changing
names.

The field named 'source_location' is being renamed to
'_source_location'. The attribute named 'unit_type_id' is being
renamed to '_content_type_id'

Your subclass likely does not define source_location, so the update
there (if any) will likely be to code that interacts with source locatio
n.

Your subclass likely does define unit_type_id, so that needs to be
renamed to '_content_type_id', and similarly you'll need to update the
code that uses it.

These *new* names are the names in use inside the DB, so this rename
is ensuring the model definition matches the data as its store inside
the database.

One thing to be aware of! If you do a grep for the original field
names you'll get a lot of false positives. For example the
RepositoryContentUnit, which is not a subclass of ContentUnit defines
unit_type_id [1]. Also the associationunits that the conduits deal
with have some false positives. When you make a change to code which
interacts with the renamed fields be sure that codepath is dealing
with the content unit which subclasses ContentUnit from platform.

I'm going to handle updating puppet and rpm, so that leaves the other
plugins for you all.

[0]: https://github.com/pulp/pulp/pull/2145
[1]:
https://github.com/pulp/pulp/blob/master/server/pulp/server/db/model/__i
nit__.py#L167

- -Brian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWM4cgAAoJEK48cdELyEfyVdoH/RjVAvINwkSaFNw+KGugWCwE
KzlnUaRpD0fJlMaHTBgCXyUHkAOAXziYM7FRwtKhw6tWL4ayaXR5+zBRUOYKpaA6
Hr+oFGnAYnFvHqo9YxiapGhru2A0CS6bUpENZZoTcPhVePIbfrIk+Oz/cgTNxcPW
VFWKxbDWLUqzCeePq9uikwsmIzFIOnkRpewXbYmFlRIDPIJ7VjqxeDCIP+PXY4B4
rCIBxENz0k0+qMK3zSbo/E572Lb3P71InRIUZuyVPGX80A6Vrtihx07h7m2tU177
z91lZonobSwhc9YJ7eSZJsRniDRuHC2eipLxtI/ZiahcvMgWWKz6Ekd72iRqypk=
=oTPc
-----END PGP SIGNATURE-----




More information about the Pulp-list mailing list