[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rdo-list] Failure to build from source for Horizon: three new dependencies (need reviews)

Thanks Haikel !

I've put up new patches with your feedback and it turns out my
fedora-review problem was a known issue when building xstatic source
Simply cleaning the fedora-review mockroot resolved that.

[1]: https://bitbucket.org/thomaswaldmann/xstatic/issues/2/cannot-build-a-new-xstatic-package-with

David Moreau Simard
Senior Software Engineer | Openstack RDO

dmsimard = [irc, github, twitter]

On Sat, Aug 6, 2016 at 3:22 AM, Haïkel Guémar <hguemar redhat com> wrote:
> On 06/08/16 05:27, David Moreau Simard wrote:
>> Hi,
>> There's a FTBFS for Horizon, they've added three new dependencies [1].
>> The review.rdo for the ftbfs is here [2].
>> Considering we're friday and we're likely to be the weekend without a
>> consistent build, I've figured I'd at least go ahead and submit
>> reviews for them ASAP.
>> These are my first package reviews ever, be nice :P
>> - XStatic-Angular-Schema-Form:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1364603
>> - XStatic-objectpath: https://bugzilla.redhat.com/show_bug.cgi?id=1364607
>> - XStatic-tv4: https://bugzilla.redhat.com/show_bug.cgi?id=1364620
>> The first one looks okay but the other two, while the koji scratch
>> build works, the fedora-review build fails.
>> It's probably an obvious mistake but I can't spot it right now. Will look later.
>> [1]: https://review.openstack.org/#/c/332745/
>> [2]: https://review.rdoproject.org/r/#/c/1807/
>> David Moreau Simard
>> Senior Software Engineer | Openstack RDO
>> dmsimard = [irc, github, twitter]
> As you're not yet a Fedora packager, I blocked the FE-NEEDSPONSOR
> tracker. Sponsoring process requires from you at least, two (good)
> informal reviews. Either Fedora or RDO-NEWTON, just link them back to
> one of your tickets.
> Feel free re-assign tickets, but until David is sponsored, just wait
> before setting fedora-review flag.
> I self-assigned the tickets as XStatic embeds javascript library. A
> reviewer that does not know that javascript libraries have a "temporary"
> bundling exception by packaging committee can make it drag on.
> Only briefly reviewed them, there are few issues here and there, easy
> fixes but not ready to be pre-imported as-is in CBS.
> Regards,
> H.
> PS: for packaging topic, you may CC jruzicka, he should be able to help.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]