[redhat-lspp] Re: [Patch] SE Linux audit events

[Timothy R. Chavez]

Hi Steve,

I just have one nit-comment on this patch below.

> 
> Signed-off-by: Steve Grubb <sgrubb at redhat.com>
> 
> 
> diff -urp linux-2.6.14.orig/include/linux/audit.h linux-2.6.14/include/linux/audit.h
> --- linux-2.6.14.orig/include/linux/audit.h     2005-12-06 12:45:15.000000000 -0500
> +++ linux-2.6.14/include/linux/audit.h  2005-12-06 13:19:01.000000000 -0500
> @@ -83,6 +83,9 @@
>  #define AUDIT_AVC              1400    /* SE Linux avc denial or grant */
>  #define AUDIT_SELINUX_ERR      1401    /* Internal SE Linux Errors */
>  #define AUDIT_AVC_PATH         1402    /* dentry, vfsmount pair from avc */
> +#define AUDIT_MAC_POLICY_LOAD  1403    /* Policy file load */
> +#define AUDIT_MAC_STATUS       1404    /* Changed enforcing,permissive,off */
> +#define AUDIT_MAC_CONFIG_CHANGE        1405    /* Changes to booleans */
> 
>  #define AUDIT_KERNEL           2000    /* Asynchronous audit record. NOT A REQUEST. */
> 
> diff -urp linux-2.6.14.orig/security/selinux/selinuxfs.c linux-2.6.14/security/selinux/selinuxfs.c
> --- linux-2.6.14.orig/security/selinux/selinuxfs.c      2005-12-06 12:45:23.000000000 -0500
> +++ linux-2.6.14/security/selinux/selinuxfs.c   2005-12-06 13:24:27.000000000 -0500
> @@ -23,6 +23,7 @@
>  #include <linux/percpu.h>
>  #include <asm/uaccess.h>
>  #include <asm/semaphore.h>
> +#include <linux/audit.h>
> 

I believe it's common practice to place linux before asm, so:

#include <linux/audit.h>
#include <asm/uaccess.h>
...

-tim