[redhat-lspp] Re: [PATCH 1/2] audit: rename AUDIT_SE_* constants

Darrel Goeddel dgoeddel at trustedcs.com
Fri Jun 30 15:22:55 UTC 2006


Stephen Smalley wrote:
> On Thu, 2006-06-29 at 16:56 -0500, Darrel Goeddel wrote:
> 
>>This patch renames some audit constant definitions and adds
>>additional definitions used by the following patch.  The renaming
>>avoids ambiguity with respect to the new definitions.
>>
>>Signed-off-by: Darrel Goeddel <dgoeddel at trustedcs.com>
>>
>> include/linux/audit.h          |   15 ++++++++----
>> kernel/auditfilter.c           |   50 ++++++++++++++++++++---------------------
>> kernel/auditsc.c               |   10 ++++----
>> security/selinux/ss/services.c |   32 +++++++++++++-------------
>> 4 files changed, 56 insertions(+), 51 deletions(-)
> 
> 
> Looks ok, although I'm not sure I'd have bothered renaming the old ones
> (and I'm not sure why you add the new definitions here rather than in
> the second patch).

This was at the request from other audit folks - hope I didn't misinterpret
that...

-- 

Darrel




More information about the redhat-lspp mailing list