<div dir="ltr">Hi, LGTM as well.  Do you plan to create a role sfconfig for instance with role action like: install, setup, recover ?<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 12, 2019 at 9:12 PM Matthieu Huin <<a href="mailto:mhuin@redhat.com">mhuin@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">LGTM<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 12, 2019 at 8:09 PM Nicolas Hicher <<a href="mailto:nhicher@redhat.com" target="_blank">nhicher@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
We have a lot of tasks on sf-ci/playbooks/tasks which need to be <br>
converted in roles to ensure we can use them in other playbooks we have <br>
to add in our ci (validate multi-tenants, multinode, ...).<br>
<br>
The plan will be to convert these tasks in roles, then replace <br>
include_tasks by include_roles [1]<br>
<br>
It the first step to the refactoring of sf-ci, but it should not be to <br>
complicated to do.<br>
<br>
What do you think, do we need to do more things for this story [2] ?<br>
<br>
Nico<br>
<br>
[1] <a href="https://docs.ansible.com/ansible/latest/modules/include_role_module.html" rel="noreferrer" target="_blank">https://docs.ansible.com/ansible/latest/modules/include_role_module.html</a><br>
<br>
[2] <a href="https://tree.taiga.io/project/morucci-software-factory/us/2069" rel="noreferrer" target="_blank">https://tree.taiga.io/project/morucci-software-factory/us/2069</a><br>
<br>
_______________________________________________<br>
Softwarefactory-dev mailing list<br>
<a href="mailto:Softwarefactory-dev@redhat.com" target="_blank">Softwarefactory-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/softwarefactory-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/softwarefactory-dev</a><br>
</blockquote></div>
_______________________________________________<br>
Softwarefactory-dev mailing list<br>
<a href="mailto:Softwarefactory-dev@redhat.com" target="_blank">Softwarefactory-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/softwarefactory-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/softwarefactory-dev</a><br>
</blockquote></div>