[sos-devel] [PATCH] acpitables plugin

[Bryn M. Reeves]

Hi Jan,

Thanks for submitting this plugin!

On 07/18/2011 01:49 PM, Jan Holcapek wrote
> +class acpitables(sos.plugintools.PluginBase):
> +	'''ACPI Tables'''
> +	def setup(self):
> +		self.addCopySpec('/sys/firmware/acpi/tables/')
> +		return

Ack to the general purpose of the patch but I think we should take care to
support older systems that still use the legacy /proc/acpi/*dt interfaces.

I don't have a strong preference on how you do that although I think it is
probably more robust to check for the presence of the /sys files first and then
fall back to /proc than to try to bind this to specific kernel version/release
numbers.

Regards,
Bryn.