From kroberts at redhat.com Mon May 9 17:31:50 2011 From: kroberts at redhat.com (Keith Robertson) Date: Mon, 09 May 2011 13:31:50 -0400 Subject: [sos-devel] JBoss SOS plug-in Message-ID: <4DC82506.9070506@redhat.com> Please consider this JBoss SOS plugin for inclusion in the official distribution. Cheers, Keith -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jboss.py URL: From bmr at redhat.com Mon May 9 18:01:22 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 09 May 2011 19:01:22 +0100 Subject: [sos-devel] JBoss SOS plug-in In-Reply-To: <4DC82506.9070506@redhat.com> References: <4DC82506.9070506@redhat.com> Message-ID: <4DC82BF2.8070602@redhat.com> On 05/09/2011 06:31 PM, Keith Robertson wrote: > Please consider this JBoss SOS plugin for inclusion in the official > distribution. > > Cheers, > Keith Hi Keith, Thanks very much for the plugin! This is a very complete plugin so it'll take a little while to review properly (I am also a little short of JBoss test environments but I am sure some of the EMEA JBoss folks can help me there) but from a quick scan it looks fine. I'll open a bug against rawhide to have this included in the upstream tree - we can then clone as appropriate for other projects/products we need to include it in. Cheers, Bryn. From kroberts at redhat.com Mon May 9 18:10:40 2011 From: kroberts at redhat.com (Keith Robertson) Date: Mon, 09 May 2011 14:10:40 -0400 Subject: [sos-devel] JBoss SOS plug-in In-Reply-To: <4DC82BF2.8070602@redhat.com> References: <4DC82506.9070506@redhat.com> <4DC82BF2.8070602@redhat.com> Message-ID: <4DC82E20.9000804@redhat.com> I can send a sample report if you're interested. Also, when you say rawhide do you mean RHEL? I'm asking because that is what I/we are most interested in seeing the SOS report in. Cheers, Keith On 05/09/2011 02:01 PM, Bryn M. Reeves wrote: > On 05/09/2011 06:31 PM, Keith Robertson wrote: >> Please consider this JBoss SOS plugin for inclusion in the official >> distribution. >> >> Cheers, >> Keith > Hi Keith, > > Thanks very much for the plugin! This is a very complete plugin so it'll take a > little while to review properly (I am also a little short of JBoss test > environments but I am sure some of the EMEA JBoss folks can help me there) but > from a quick scan it looks fine. > > I'll open a bug against rawhide to have this included in the upstream tree - we > can then clone as appropriate for other projects/products we need to include it in. > > Cheers, > Bryn. > From bmr at redhat.com Mon May 9 18:21:17 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 09 May 2011 19:21:17 +0100 Subject: [sos-devel] JBoss SOS plug-in In-Reply-To: <4DC82E20.9000804@redhat.com> References: <4DC82506.9070506@redhat.com> <4DC82BF2.8070602@redhat.com> <4DC82E20.9000804@redhat.com> Message-ID: <4DC8309D.2080405@redhat.com> On 05/09/2011 07:10 PM, Keith Robertson wrote: > I can send a sample report if you're interested. That would be really useful, thanks! Probably be a bit big to send to the list but if you can either pass it to me privately (I'll add it to our "examples" repo which will hopefully soon be public) or if you have a URL I'll pull it from there. > Also, when you say rawhide do you mean RHEL? I'm asking because that is > what I/we are most interested in seeing the SOS report in. Sorry I should have explained better - since sos is a Fedorahosted project we use Fedora Rawhide bugs to track new features upstream. If you look at the "Fedora" products list there should be a "rawhide" version listed - We can start the bug there, get it into git upstream and the rawhide package and then clone and either backport or rebase as appropriate for RHEL or other products. This should all be in the extensive project documentation that I have so far failed to write! Cheers, Bryn. From kroberts at redhat.com Mon May 9 18:29:14 2011 From: kroberts at redhat.com (Keith Robertson) Date: Mon, 09 May 2011 14:29:14 -0400 Subject: [sos-devel] JBoss SOS plug-in In-Reply-To: <4DC8309D.2080405@redhat.com> References: <4DC82506.9070506@redhat.com> <4DC82BF2.8070602@redhat.com> <4DC82E20.9000804@redhat.com> <4DC8309D.2080405@redhat.com> Message-ID: <4DC8327A.7080700@redhat.com> On 05/09/2011 02:21 PM, Bryn M. Reeves wrote: > "Fedora" products list there should be a "rawhide" version listed - We can start > the bug there, get it into git upstream and the rawhide package and then clone > and either backport or rebase as appropriate for RHEL or other products. I think the team would very much like to see this in RHEL 5 & 6. There are no external python dependencies and the SOS plug-in will work on both. From bmr at redhat.com Mon May 9 18:31:20 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 09 May 2011 19:31:20 +0100 Subject: [sos-devel] JBoss SOS plug-in In-Reply-To: <4DC8327A.7080700@redhat.com> References: <4DC82506.9070506@redhat.com> <4DC82BF2.8070602@redhat.com> <4DC82E20.9000804@redhat.com> <4DC8309D.2080405@redhat.com> <4DC8327A.7080700@redhat.com> Message-ID: <4DC832F8.5030907@redhat.com> On 05/09/2011 07:29 PM, Keith Robertson wrote: > On 05/09/2011 02:21 PM, Bryn M. Reeves wrote: >> "Fedora" products list there should be a "rawhide" version listed - We can start >> the bug there, get it into git upstream and the rawhide package and then clone >> and either backport or rebase as appropriate for RHEL or other products. > I think the team would very much like to see this in RHEL 5 & 6. There > are no external python dependencies and the SOS plug-in will work on both. Yep - that's how we're doing most new features at the moment. There's very little right now that can't go to both branches in some form or another. Regards, Bryn. From kroberts at redhat.com Tue May 10 01:24:29 2011 From: kroberts at redhat.com (Keith Robertson) Date: Mon, 9 May 2011 21:24:29 -0400 (EDT) Subject: [sos-devel] GIT Repo for SOS? Message-ID: <1780709713.512734.1304990669204.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> Can someone tell me where the GIT repo for SOS report is? I'd like to make some changes to some of the stock plug-ins? Cheers, Keith Keith Robertson 1-919-754-4004 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bmr at redhat.com Tue May 10 10:34:36 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 10 May 2011 11:34:36 +0100 Subject: [sos-devel] GIT Repo for SOS? In-Reply-To: <1780709713.512734.1304990669204.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> References: <1780709713.512734.1304990669204.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> Message-ID: <4DC914BC.90804@redhat.com> On 05/10/2011 02:24 AM, Keith Robertson wrote: > Can someone tell me where the GIT repo for SOS report is? I'd like to make some > changes to some of the stock plug-ins? > > Cheers, > Keith > Sure thing, here are the important URLs: Trac browser [ legacy as we migrated from svn-- to git++ ]: https://git.fedorahosted.org/sos/browser Gitweb: http://git.fedorahosted.org/git/?p=sos.git Clone URL: git://git.fedorahosted.org/sos.git Regards, Bryn. From kroberts at redhat.com Tue May 10 13:59:38 2011 From: kroberts at redhat.com (Keith Robertson) Date: Tue, 10 May 2011 09:59:38 -0400 Subject: [sos-devel] [PATCH 1/2] devicemapper enhancements 1. Changed paths to pvs, vgscan, and lvs 2. Added 3 lvm commands that support usually requests 3. Added iostat command to get device stats 4. Fixed some indentation issues. 5. Removed an unused import Message-ID: <1305035979-6166-1-git-send-email-kroberts@redhat.com> --- sos/plugins/devicemapper.py | 28 ++++++++++++++++------------ 1 files changed, 16 insertions(+), 12 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-devicemapper-enhancements.patch Type: text/x-patch Size: 2671 bytes Desc: not available URL: From kroberts at redhat.com Tue May 10 13:59:39 2011 From: kroberts at redhat.com (Keith Robertson) Date: Tue, 10 May 2011 09:59:39 -0400 Subject: [sos-devel] [PATCH 2/2] iscsi enhancements 1. Added some useful commands to get more info about iscsi devices In-Reply-To: <1305035979-6166-1-git-send-email-kroberts@redhat.com> References: <1305035979-6166-1-git-send-email-kroberts@redhat.com> Message-ID: <1305035979-6166-2-git-send-email-kroberts@redhat.com> --- sos/plugins/iscsi.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-iscsi-enhancements.patch Type: text/x-patch Size: 508 bytes Desc: not available URL: From bmr at redhat.com Tue May 10 14:08:11 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 10 May 2011 15:08:11 +0100 Subject: [sos-devel] [PATCH 2/2] iscsi enhancements 1. Added some useful commands to get more info about iscsi devices In-Reply-To: <1305035979-6166-2-git-send-email-kroberts@redhat.com> References: <1305035979-6166-1-git-send-email-kroberts@redhat.com> <1305035979-6166-2-git-send-email-kroberts@redhat.com> Message-ID: <4DC946CB.3040400@redhat.com> On 05/10/2011 02:59 PM, Keith Robertson wrote: > --- > sos/plugins/iscsi.py | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Ack. Thanks again! May I assume a Signed-off-by line for both patches? We're trying to get all contributions to include a DCO now (again, something I need to document!). Have a couple of comments on the other patch (nothing major, just cmdline opts etc.) but I have a call in a moment so will have to get back to you a little later. Regards, Bryn. From kroberts at redhat.com Tue May 10 14:22:35 2011 From: kroberts at redhat.com (Keith Robertson) Date: Tue, 10 May 2011 10:22:35 -0400 (EDT) Subject: [sos-devel] [PATCH 2/2] iscsi enhancements 1. Added some useful commands to get more info about iscsi devices In-Reply-To: <4DC946CB.3040400@redhat.com> Message-ID: <1820654105.524670.1305037355002.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> You're welcome. As for the " Signed-off-by" line, sure. I disabled that in my .gitconfig because another GIT repo I use doesn't like it. I'll have to investigate enabling/disabling it per repo. Cheers, Keith Keith Robertson Signed-off-by 1-919-754-4004 ----- Original Message ----- From: "Bryn M. Reeves" To: "Keith Robertson" Cc: sos-devel at redhat.com Sent: Tuesday, May 10, 2011 10:08:11 AM Subject: Re: [sos-devel] [PATCH 2/2] iscsi enhancements 1. Added some useful commands to get more info about iscsi devices On 05/10/2011 02:59 PM, Keith Robertson wrote: > --- > sos/plugins/iscsi.py | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Ack. Thanks again! May I assume a Signed-off-by line for both patches? We're trying to get all contributions to include a DCO now (again, something I need to document!). Have a couple of comments on the other patch (nothing major, just cmdline opts etc.) but I have a call in a moment so will have to get back to you a little later. Regards, Bryn. -------------- next part -------------- An HTML attachment was scrubbed... URL: