From kroberts at redhat.com Wed Nov 9 20:15:57 2011 From: kroberts at redhat.com (Keith Robertson) Date: Wed, 09 Nov 2011 15:15:57 -0500 Subject: [sos-devel] Gluster SoS plugin Message-ID: <4EBADF7D.2060003@redhat.com> Please find the gluster SoS plugin attached. There is an associated BZ for it and it is... https://bugzilla.redhat.com/show_bug.cgi?id=752549 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: gluster.py URL: From bmr at redhat.com Thu Nov 10 11:11:49 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Thu, 10 Nov 2011 11:11:49 +0000 Subject: [sos-devel] Gluster SoS plugin In-Reply-To: <4EBADF7D.2060003@redhat.com> References: <4EBADF7D.2060003@redhat.com> Message-ID: <4EBBB175.80106@redhat.com> On 11/09/2011 08:15 PM, Keith Robertson wrote: > ### This program is free software; you can redistribute it and/or modify > ## it under the terms of the GNU General Public License as published by > ## the Free Software Foundation; either version 2 of the License, or > ## (at your option) any later version. > > ## This program is distributed in the hope that it will be useful, > ## but WITHOUT ANY WARRANTY; without even the implied warranty of > ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > ## GNU General Public License for more details. > > ## You should have received a copy of the GNU General Public License > ## along with this program; if not, write to the Free Software > ## Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > > import sos.plugintools > > class gluster(sos.plugintools.PluginBase): > '''gluster related information''' > > def setup(self): > self.addCopySpecs(["/etc/glusterd/","/var/log/glusterfs/"]) Acked-by: Bryn M. Reeves Cheers, Bryn. From kroberts at redhat.com Thu Nov 10 13:41:23 2011 From: kroberts at redhat.com (Keith Robertson) Date: Thu, 10 Nov 2011 08:41:23 -0500 Subject: [sos-devel] Updated gluster plugin Message-ID: <4EBBD483.8030800@redhat.com> Previous one didn't work on RHEL 6.1 due to a missing addCopySpecs method. I just broke it out into individual calls so that it will work in more places. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: gluster.py URL: From bmr at redhat.com Thu Nov 10 14:41:00 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Thu, 10 Nov 2011 14:41:00 +0000 Subject: [sos-devel] Updated gluster plugin In-Reply-To: <4EBBD483.8030800@redhat.com> References: <4EBBD483.8030800@redhat.com> Message-ID: <4EBBE27C.6090207@redhat.com> On 11/10/2011 01:41 PM, Keith Robertson wrote: > Previous one didn't work on RHEL 6.1 due to a missing addCopySpecs > method. I just broke it out into individual calls so that it will work Ah, yeah, good point. > import sos.plugintools > > class gluster(sos.plugintools.PluginBase): > '''gluster related information''' Also probably should implement checkenabled() here, something like: def checkenabled(self): return os.path.exists("/etc/glusterd") So we don't log errors if the file paths don't exist. > def setup(self): > self.addCopySpec("/etc/glusterd/") > self.addCopySpec("/var/log/glusterfs/") Cheers, Bryn. From ndevos at redhat.com Thu Nov 10 15:57:52 2011 From: ndevos at redhat.com (Niels de Vos) Date: Thu, 10 Nov 2011 10:57:52 -0500 Subject: [sos-devel] Updated gluster plugin In-Reply-To: <4EBBD483.8030800@redhat.com> References: <4EBBD483.8030800@redhat.com> Message-ID: <4EBBF480.9070906@redhat.com> On 11/10/2011 08:41 AM, Keith Robertson wrote: > Previous one didn't work on RHEL 6.1 due to a missing addCopySpecs > method. I just broke it out into individual calls so that it will > work in more places. Installation: [root at localhost ~]# cp /tmp/gluster.py /usr/lib/python2.6/site-packages/sos/plugins Checking if the plugin is enabled: [root at localhost ~]# sosreport -l | grep -e enabled -e disabled -e gluster The following plugins are currently enabled: gluster gluster related information The following plugins are currently disabled: The resulting sosreport contains all the files we need. Therefore, feel free to add: Tested-by: Niels de Vos Thanks, Niels -- Niels de Vos Software Maintenance Engineer Global Support Services Red Hat UK, Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: OpenPGP digital signature URL: From plambri at redhat.com Tue Nov 15 18:09:37 2011 From: plambri at redhat.com (Pierguido Lambri) Date: Tue, 15 Nov 2011 18:09:37 +0000 Subject: [sos-devel] NIS plugin Message-ID: <4EC2AAE1.2090102@redhat.com> Hi all, I know that NIS is not much used any more, but some times it would be nice to have the NIS configurations gathered. I wrote this simple plugin for the NIS options and data. Thanks, Pier -------------- next part -------------- A non-text attachment was scrubbed... Name: nis.py Type: text/x-python Size: 1039 bytes Desc: not available URL: From bmr at redhat.com Mon Nov 21 12:23:53 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 21 Nov 2011 12:23:53 +0000 Subject: [sos-devel] [PATCH][git] Import internationalisation functions in policies Message-ID: <4ECA42D9.7000008@redhat.com> Hi Folks, Was playing around with git HEAD at the weekend and ran into a missing definition for _() in the policy classes. Cheers, Bryn. commit becd135ba3bf6a658b0310aa72e1f9d5b4994471 Author: Bryn M. Reeves Date: Fri Nov 18 16:18:21 2011 +0000 Import internationalisation from sos in policies/__init__.py diff --git a/sos/policies/__init__.py b/sos/policies/__init__.py index 0415b05..fc97637 100644 --- a/sos/policies/__init__.py +++ b/sos/policies/__init__.py @@ -2,6 +2,7 @@ import os import platform import time +from sos import _sos as _ from sos.utilities import ImporterHelper, import_module from sos.plugins import IndependentPlugin @@ -60,7 +61,7 @@ and it will be considered confidential information. This process may take a while to complete. No changes will be made to your system. -""" +""") distro = "" From jjaggars at redhat.com Mon Nov 21 15:06:34 2011 From: jjaggars at redhat.com (Jesse Jaggars) Date: Mon, 21 Nov 2011 10:06:34 -0500 (EST) Subject: [sos-devel] [PATCH][git] Import internationalisation functions in policies In-Reply-To: <4ECA42D9.7000008@redhat.com> Message-ID: Hey Bryn, Maybe you snagged a stale copy? The current plugin_refactoring branch (an unfortunate name at this point) has that import already: https://github.com/sosreport/sosreport/blob/plugin_refactoring/sos/policies/__init__.py Thanks, Jesse ----- Original Message ----- Hi Folks, Was playing around with git HEAD at the weekend and ran into a missing definition for _() in the policy classes. Cheers, Bryn. commit becd135ba3bf6a658b0310aa72e1f9d5b4994471 Author: Bryn M. Reeves Date: Fri Nov 18 16:18:21 2011 +0000 Import internationalisation from sos in policies/__init__.py diff --git a/sos/policies/__init__.py b/sos/policies/__init__.py index 0415b05..fc97637 100644 --- a/sos/policies/__init__.py +++ b/sos/policies/__init__.py @@ -2,6 +2,7 @@ import os import platform import time +from sos import _sos as _ from sos.utilities import ImporterHelper, import_module from sos.plugins import IndependentPlugin @@ -60,7 +61,7 @@ and it will be considered confidential information. This process may take a while to complete. No changes will be made to your system. -""" +""") distro = "" _______________________________________________ Sos-devel mailing list Sos-devel at redhat.com https://www.redhat.com/mailman/listinfo/sos-devel From bmr at redhat.com Mon Nov 21 15:38:55 2011 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 21 Nov 2011 15:38:55 +0000 Subject: [sos-devel] [PATCH][git] Import internationalisation functions in policies In-Reply-To: References: Message-ID: <4ECA708F.7020609@redhat.com> On 11/21/2011 03:06 PM, Jesse Jaggars wrote: > Hey Bryn, > > Maybe you snagged a stale copy? The current plugin_refactoring branch (an unfortunate name at this point) has that import already: > > https://github.com/sosreport/sosreport/blob/plugin_refactoring/sos/policies/__init__.py > > Thanks, > Jesse Hi Jesse, Thanks - I cloned a fresh copy and hit this on Friday - looks like I grabbed it a couple of hours before this hit: commit 9ddd583eb802f15a5bd0dabe177221b7a5bdbb90 Author: Jesse Jaggars Date: Fri Nov 18 10:54:22 2011 -0600 Working on os X build issues Didn't twig from the commit message that this was making the same change. Along with the hunk that adds _() I noticed this: +from sos import _sos as _ + +try: + from hashlib import md5 +except ImportError: + from md5 import md5 We need to be careful using crypto libraries in sos since the available set of cyphers is influenced by FIPS mode (which we need to support in RHEL). The RHEL-6 branch already has changes to cope with this - see sos-bz689387-use-sha256-in-fips-mode.patch. Cheers, Bryn.