[sos-devel] [PATCH][git] Import internationalisation functions in policies

[Bryn M. Reeves]

On 11/21/2011 03:06 PM, Jesse Jaggars wrote:
> Hey Bryn,
>
> Maybe you snagged a stale copy? The current plugin_refactoring branch (an unfortunate name at this point) has that import already:
>
> https://github.com/sosreport/sosreport/blob/plugin_refactoring/sos/policies/__init__.py
>
> Thanks,
> Jesse

Hi Jesse,

Thanks - I cloned a fresh copy and hit this on Friday - looks like I 
grabbed it a couple of hours before this hit:

commit 9ddd583eb802f15a5bd0dabe177221b7a5bdbb90
Author: Jesse Jaggars <jhjaggars at gmail.com>
Date:   Fri Nov 18 10:54:22 2011 -0600

     Working on os X build issues

Didn't twig from the commit message that this was making the same change.

Along with the hunk that adds _() I noticed this:

+from sos import _sos as _
+
+try:
+    from hashlib import md5
+except ImportError:
+    from md5 import md5

We need to be careful using crypto libraries in sos since the available 
set of cyphers is influenced by FIPS mode (which we need to support in 
RHEL).

The RHEL-6 branch already has changes to cope with this - see 
sos-bz689387-use-sha256-in-fips-mode.patch.

Cheers,
Bryn.