[sos-devel] [PATCH 0/3] Series:Adding Power support to sosreport

[Bryn M. Reeves]

On 10/25/2013 07:32 AM, Bharani C.V wrote:
> The following series adds Power Systems plugin to sosreport.
> So we add a check in each policy -RedHat,Ubuntu and Debian 
> to see if sosreport is being run on power platform by 
> checking output of #uname -m
> 	 If the check is passed i.e., it is indeed power system,
> then PowerPlugin class is list as valid subclass for that distribution.
> We define PowerPlugin class and a new PowerPC Plugin has been added
> which runs and collects generic Power logs . Based on further platform
> checks,IBM Power System specific logs and commands will be collected.
> This would help IBM Power system users to collect system data in one
> shot by running sosreport.

Thanks very much for submitting this. The PowerPC plugin itself looks good.

I'm not sure that tagging classes are the best approach for controlling
the plug-in activation however. There is already a get_arch() method
defined in the policy classes that returns the collection host's
architecture formatted as a string. This is used e.g. in the s390
plug-in's check_enabled() method to determine whether nor not the
plug-in should run. The processor plug-in uses the same method to decide
whether or not to run the x86info program.

If we're going to adopt tagging classes for architectures then I think
we should change this across the tree rather than leave several
implementations lying around but I'm not convinced that they are a major
improvement over the simple method call.

What do you see as the advantage?

Regards,
Bryn.