[sos-devel] [PATCH v2] sosreport: Accept commas, period and alphas in the case id

Bryn M. Reeves bmr at redhat.com
Wed Aug 20 08:46:31 UTC 2014


On Wed, Aug 20, 2014 at 01:43:22PM +0530, Aruna Balakrishnaiah wrote:
>     If case_id is not the appropriate name, please suggest me
> the name I could use.

Thanks for taking the time to rework the patch and add the documentation
changes.

I'm actually happy with that name, although as I said on GitHub, I think it
may make sense to support multiple synonyms for this attribute - they all
ultimately mean the same thing and it would mean that users of a particular
vendor's products can use the term that the vendor itself uses (or at least
something close). Allowing synonyms is a lot simpler to implement than
creating a mechanism to allow the policy to control the names of command
line options (which was the other option I'd considered).

If there seems to be agreement from the other main developers I'll aim to
get this merged today.

Regards,
Bryn.

> >-        parser.add_option("--ticket-number", action="store",
> >-                             dest="ticket_number",
> >-                             help="specify ticket number")
> >+        parser.add_option("--case-id", action="store",
> >+                             dest="case_id",
> >+                             help="specify case id")
> >          parser.add_option("--name", action="store",
> >                               dest="customer_name",
> >                               help="specify report name")




More information about the sos-devel mailing list