[sos-devel] [PATCH] sos: collect /etc/rhevm

[Bryn M. Reeves]

On Tue, Aug 12, 2014 at 09:01:33AM +0200, Sandro Bonazzola wrote:
> diff --git a/sos/plugins/ovirt.py b/sos/plugins/ovirt.py
> index 38bc542..d13e540 100644
> --- a/sos/plugins/ovirt.py
> +++ b/sos/plugins/ovirt.py
> @@ -85,7 +85,7 @@ class Ovirt(Plugin, RedHatPlugin):
>          # Copy engine config files.
>          self.add_copy_specs([
>              "/etc/ovirt-engine",
> -            "/etc/rhevm",
> +            "/etc/rhevm/*",

I've modified this to use '/etc/rhevm/' as the path - I've just tested
this with current master and this gives the desired behaviour:

   Setting up archive ...
  [archive:TarFileArchive] initialised empty FileCacheArchive at '/var/tmp/sosreport-localhost.localdomain-20140828091214'
   Setting up plugins ...
  [plugin:test] added copyspec '/etc/rhevm/'
   Running plugins. Please wait ...
  
    Running 1/1: test...        
  [plugin:test] collecting path '/etc/rhevm/'
  [plugin:test] recursively adding 'README' from '/etc/rhevm/'
  [plugin:test] copying path '/etc/rhevm/README' to archive:'/etc/rhevm/README'
  [plugin:test] recursively adding 'bar' from '/etc/rhevm/'
  [plugin:test] copying path '/etc/rhevm/bar' to archive:'/etc/rhevm/bar'
  [plugin:test] recursively adding 'foo' from '/etc/rhevm/'
  [plugin:test] copying path '/etc/rhevm/foo' to archive:'/etc/rhevm/foo'
  [plugin:test] collected plugin 'test' in 0.00110387802124

The only drawback of using the traling '/' is that it will turn the link
into an actual directory. We can revisit this once the remaining path
traversal changes are in.

Cheers,
Bryn.