[sos-devel] [RESEND PATCH v3] sosreport: Capture IBM Power RAID storage adapter configuration information

[Bryn M. Reeves]

On Thu, Nov 06, 2014 at 10:26:23AM +0530, Aruna Balakrishnaiah wrote:
> Bryn,
> 
> Is the patch ok? Can we expect it to be merged in the next release?

Hi Aruna,

Sorry for the delay; I've been busy with some other projects lately
and have a bit of a backlog of sos patches to work through.

There are a number of minor issues with the patch; mostly pep8
problems:

$ .git/hooks/pre-commit
checking pep8 conformance
sos/plugins/iprconfig.py:22:1: E302 expected 2 blank lines, found 1
sos/plugins/iprconfig.py:43:16: E111 indentation is not a multiple of four
[...]

It's a good idea to run the pep8 conformance tool (and also the sos
testsuite) for each patch - there were a number of lines with 3-char
indents (python requires a multiple of four).

I'll post a revised patch in a moment if you'd be able to test it
we can get it merged.

Regards,
Bryn.