[sos-devel] [PATCH v3] Add plugin for Kimchi

[Bryn M. Reeves]

On Thu, Dec 11, 2014 at 04:12:20PM -0600, Christy Perez wrote:
> This plugin gathers kimchi logs and configuration files.
> 
> Kimchi is an HTML5-based virtualization-management platform
> For more information, please visit:
> https://github.com/kimchi-project/kimchi/wiki
> 
> Signed-off-by: Christy Perez <christy at linux.vnet.ibm.com>

Hi Christy,

Thanks for revising the plugin - I think this looks good now. One minor
thing - the two options you're using ('all_logs' and 'log_size') are
actually global options now so there's no need for plugins to declare
them individually in their option_list. You can find more info on the
feature here:

  https://github.com/sosreport/sos/wiki/Plugin-options

It's a trivial fixup though so I'll go ahead and remove the option_list
and get this committed & pushed.

Regards,
Bryn.

> ---
> +    option_list = [('logsize', 'maximum size (MiB) of each log file', '', 15),
> +                   ('all_logs', 'collect all logs, regardless of size', '',
> +                    False)
> +                   ]
> +