[sos-devel] [PATCH v3] Add plugin for Kimchi

[Christy Perez]

On 12/16/2014 06:48 AM, Bryn M. Reeves wrote:
> On Tue, Dec 16, 2014 at 12:42:55PM +0000, Bryn M. Reeves wrote:
>> On Thu, Dec 11, 2014 at 04:12:20PM -0600, Christy Perez wrote:
>>> This plugin gathers kimchi logs and configuration files.
>>>
>>> Kimchi is an HTML5-based virtualization-management platform
>>> For more information, please visit:
>>> https://github.com/kimchi-project/kimchi/wiki
>>>
>>> Signed-off-by: Christy Perez <christy at linux.vnet.ibm.com>
>>
>> Hi Christy,
>>
>> Thanks for revising the plugin - I think this looks good now. One minor
>> thing - the two options you're using ('all_logs' and 'log_size') are
>> actually global options now so there's no need for plugins to declare
>> them individually in their option_list. You can find more info on the
>> feature here:
>>
>>   https://github.com/sosreport/sos/wiki/Plugin-options
>>
>> It's a trivial fixup though so I'll go ahead and remove the option_list
>> and get this committed & pushed.

Thanks so much!

> 
> Pushed, thanks!
> 
> commit 3aabd18b2666dbbeb86871ac4b9f025e468d5818
> Author: Christy Perez <christy at linux.vnet.ibm.com>
> Date:   Tue Dec 16 12:46:27 2014 +0000
> 
>     [kimchi] add new plugin
>     
>     This plugin gathers kimchi logs and configuration files.
>     
>     Kimchi is an HTML5-based virtualization-management platform
>     For more information, please visit:
>     https://github.com/kimchi-project/kimchi/wiki
>     
>     Signed-off-by: Christy Perez <christy at linux.vnet.ibm.com>
>     Signed-off-by: Bryn M. Reeves <bmr at redhat.com>
> 
>