From hegdevasant at linux.vnet.ibm.com Tue Jul 1 06:31:21 2014 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 01 Jul 2014 12:01:21 +0530 Subject: [sos-devel] [PATCH RESEND] powerpc: Collect selected file instead of entire directory In-Reply-To: <20140630172515.GE14765@localhost.localdomain> References: <20140616073102.22564.1734.stgit@hegdevasant.in.ibm.com> <53AC35AD.3060804@linux.vnet.ibm.com> <20140630170832.GD14765@localhost.localdomain> <20140630172515.GE14765@localhost.localdomain> Message-ID: <53B255B9.8040706@linux.vnet.ibm.com> On 06/30/2014 10:55 PM, Bryn M. Reeves wrote: > On Mon, Jun 30, 2014 at 06:08:33PM +0100, Bryn M. Reeves wrote: >> Applied as commit 797166a: >> >> commit 797166abec941a8e255567acff674f6c437ea12e >> Author: Bryn M. Reeves >> Date: Mon Jun 30 18:06:35 2014 +0100 > > Sorry - make that commit 797166a (rebased over today's master). Looks good. Thanks Bryn. -Vasant From notifications at travis-ci.org Wed Jul 2 10:56:26 2014 From: notifications at travis-ci.org (Travis CI) Date: Wed, 02 Jul 2014 10:56:26 +0000 Subject: [sos-devel] Broken: sosreport/sos#338 (master - 9a128b9) In-Reply-To: Message-ID: <53b3e55945178_2edf45c336780@814309d3-751b-4002-a082-a25b44fbb1ee.mail> Build Update for sosreport/sos ------------------------------------- Build: #338 Status: Broken Duration: 25 seconds Commit: 9a128b9 (master) Author: Bryn M. Reeves Message: [plugin] handle lstat exceptions in do_copy_path() Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/5d1225e947b6...9a128b957c25 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/28949871 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Wed Jul 2 11:13:17 2014 From: notifications at travis-ci.org (Travis CI) Date: Wed, 02 Jul 2014 11:13:17 +0000 Subject: [sos-devel] Fixed: sosreport/sos#339 (master - 1834e14) In-Reply-To: Message-ID: <53b3e94cd9c60_2f2b3be342973@814309d3-751b-4002-a082-a25b44fbb1ee.mail> Build Update for sosreport/sos ------------------------------------- Build: #339 Status: Fixed Duration: 44 seconds Commit: 1834e14 (master) Author: Bryn M. Reeves Message: [plugin] python3 exception lists must be tuples Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/9a128b957c25...1834e147d1ff View the full build log and details: https://travis-ci.org/sosreport/sos/builds/28951161 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From bmr at redhat.com Thu Jul 10 10:23:23 2014 From: bmr at redhat.com (Bryn M. Reeves) Date: Thu, 10 Jul 2014 11:23:23 +0100 Subject: [sos-devel] [PATCH] sosreport: Accept commas, period and alphas in the case number In-Reply-To: <20140710100953.22739.78634.stgit@aruna-ThinkPad-T420> References: <20140710100953.22739.78634.stgit@aruna-ThinkPad-T420> Message-ID: <20140710102322.GC2207@localhost.localdomain> On Thu, Jul 10, 2014 at 03:40:00PM +0530, Aruna Balakrishnaiah wrote: > sosreport does not accept commas, period and alphas in the case > number, the patch fixes the same. > > Signed-off-by: Aruna Balakrishnaiah This is intentional (it's a number). Why do you want to have commas, periods, and alphas in the ticket number field? We also use the dash as a field separator in constructed file and directory names so that is also filtered out by the current sanitisation. Regards, Bryn. > def sanitize_ticket_number(self, ticket_number): > - return re.sub(r"[^0-9]", "", ticket_number) > + return re.sub(r"[^-a-z,A-Z.0-9]", "", ticket_number) From aruna at linux.vnet.ibm.com Thu Jul 10 10:10:00 2014 From: aruna at linux.vnet.ibm.com (Aruna Balakrishnaiah) Date: Thu, 10 Jul 2014 15:40:00 +0530 Subject: [sos-devel] [PATCH] sosreport: Accept commas, period and alphas in the case number Message-ID: <20140710100953.22739.78634.stgit@aruna-ThinkPad-T420> sosreport does not accept commas, period and alphas in the case number, the patch fixes the same. Signed-off-by: Aruna Balakrishnaiah --- sos/policies/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sos/policies/__init__.py b/sos/policies/__init__.py index 11995ff..55919f9 100644 --- a/sos/policies/__init__.py +++ b/sos/policies/__init__.py @@ -383,7 +383,7 @@ class LinuxPolicy(Policy): return re.sub(r"[^-a-zA-Z.0-9]", "", report_name) def sanitize_ticket_number(self, ticket_number): - return re.sub(r"[^0-9]", "", ticket_number) + return re.sub(r"[^-a-z,A-Z.0-9]", "", ticket_number) def pre_work(self): # this method will be called before the gathering begins From aruna at linux.vnet.ibm.com Fri Jul 11 05:42:35 2014 From: aruna at linux.vnet.ibm.com (Aruna Balakrishnaiah) Date: Fri, 11 Jul 2014 11:12:35 +0530 Subject: [sos-devel] [PATCH] sosreport: Accept commas, period and alphas in the case number In-Reply-To: <20140710102322.GC2207@localhost.localdomain> References: <20140710100953.22739.78634.stgit@aruna-ThinkPad-T420> <20140710102322.GC2207@localhost.localdomain> Message-ID: <53BF794B.5010209@linux.vnet.ibm.com> On Thursday 10 July 2014 03:53 PM, Bryn M. Reeves wrote: Hi Bryn, > On Thu, Jul 10, 2014 at 03:40:00PM +0530, Aruna Balakrishnaiah wrote: >> sosreport does not accept commas, period and alphas in the case >> number, the patch fixes the same. >> >> Signed-off-by: Aruna Balakrishnaiah > This is intentional (it's a number). Why do you want to have commas, > periods, and alphas in the ticket number field? In our existing ticket model we use all those chars like 123,7RN,43 so its nice to have this format. If not, can we atleast have alphas? Regards, Aruna > We also use the dash as a field separator in constructed file and > directory names so that is also filtered out by the current > sanitisation. > > Regards, > Bryn. > >> def sanitize_ticket_number(self, ticket_number): >> - return re.sub(r"[^0-9]", "", ticket_number) >> + return re.sub(r"[^-a-z,A-Z.0-9]", "", ticket_number) From bmr at redhat.com Fri Jul 11 13:53:16 2014 From: bmr at redhat.com (Bryn M. Reeves) Date: Fri, 11 Jul 2014 14:53:16 +0100 Subject: [sos-devel] [PATCH] sosreport: Accept commas, period and alphas in the case number In-Reply-To: <53BF794B.5010209@linux.vnet.ibm.com> References: <20140710100953.22739.78634.stgit@aruna-ThinkPad-T420> <20140710102322.GC2207@localhost.localdomain> <53BF794B.5010209@linux.vnet.ibm.com> Message-ID: <20140711135316.GB4924@localhost.localdomain> On Fri, Jul 11, 2014 at 11:12:35AM +0530, Aruna Balakrishnaiah wrote: > In our existing ticket model we use all those chars like 123,7RN,43 > so its nice to have this format. > > If not, can we atleast have alphas? OK, so this is the type of major user-visible policy change that really needs to be discussed on the list so that we can form a consensus before going ahead with code changes. To date the users of sos have only had a need for numerical ticket identifiers and if we're going to move away from that there are other considerations we should weigh up first. In no particular order: - The ticket-number field is encoded in the file names sos generates o What characters are permissible in all supported file systems? o Should we further restrict the set to ensure compatibility with other interchange file systems, e.g. FAT? - If we're allowing non-numeric ticket/case identifiers then it's not really appropriate to call the option 'ticket-number' so we'll need to come up with an appropriate name and update all the documentation. - Our current directory/tarball names are a bit unweildy and hard to parse visually. If we're going to make changes here we should get them all done together to minimize the number of variations and to keep user disruption to a minimum. - Few users actually seem to use the ticket number field today (in a not-very-scientific-sample of reports I have lying around about 30% had a valid case identifier in this field). - Is it a ticket number, a case identifier, an incident #? Differnt support organisations have different terminologies and different validation rules: should this be under policy control? [note: a major complication with this is that to date we have not made any command line options controllable via policy. We don't currently have a mechanism to make that work and it would require quite a lot of reorganisation to fit into the current structure of the sosreport command.] So I think this needs further discussion and consideration before we can come to an agreement. Given that a lot of the contributors today are via GitHub I think opening an issue there for discussion is the best way forwards. Regards, Bryn. From notifications at travis-ci.org Tue Jul 15 17:13:51 2014 From: notifications at travis-ci.org (Travis CI) Date: Tue, 15 Jul 2014 17:13:51 +0000 Subject: [sos-devel] Broken: sosreport/sos#359 (master - d135ab7) In-Reply-To: Message-ID: <53c5614e923d8_211eeada425771@0baeff56-b7d6-48d0-9d42-f72de2e59111.mail> Build Update for sosreport/sos ------------------------------------- Build: #359 Status: Broken Duration: 1 minute and 0 seconds Commit: d135ab7 (master) Author: Bryn M. Reeves Message: [general] delete UbuntuGeneral and incorporate into General The UbuntuGeneral plugin just collects '/etc/os-release' which is not specific to Ubuntu distributions. Move it to the General class itself and delete the child class. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/c6c9693507ca...d135ab702824 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/29999684 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Tue Jul 15 17:45:52 2014 From: notifications at travis-ci.org (Travis CI) Date: Tue, 15 Jul 2014 17:45:52 +0000 Subject: [sos-devel] Fixed: sosreport/sos#360 (master - 88fdafe) In-Reply-To: Message-ID: <53c568ce88f68_212973b0442956@0baeff56-b7d6-48d0-9d42-f72de2e59111.mail> Build Update for sosreport/sos ------------------------------------- Build: #360 Status: Fixed Duration: 30 seconds Commit: 88fdafe (master) Author: Bryn M. Reeves Message: [archive] remove python2 debug code from class Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/d135ab702824...88fdafe606d2 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/30002629 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Thu Jul 31 16:26:28 2014 From: notifications at travis-ci.org (Travis CI) Date: Thu, 31 Jul 2014 16:26:28 +0000 Subject: [sos-devel] Passed: sosreport/sos#369 (patch-pep8-sosreport.py - 306b7fe) In-Reply-To: Message-ID: <53da6e33280a0_29c7faa2925de@d8499bd2-1915-4af8-b115-02120dd930a7.mail> Build Update for sosreport/sos ------------------------------------- Build: #369 Status: Passed Duration: 3 minutes and 23 seconds Commit: 306b7fe (patch-pep8-sosreport.py) Author: Adam Stokes Message: [sosreport] make pep8 happy There were a ton of violations as far as pep8 is concerned. Corrected all of these in this particular file. There were even a few incorrect comparison syntax within the checking of particular plugin options that were corrected as well. Signed-off-by: Adam Stokes View the changeset: https://github.com/sosreport/sos/commit/306b7fe27456 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/31347310 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: