[sos-devel] [PATCH] sosreport: Accept commas, period and alphas in the case number

[Aruna Balakrishnaiah]

On Thursday 10 July 2014 03:53 PM, Bryn M. Reeves wrote:

Hi Bryn,

> On Thu, Jul 10, 2014 at 03:40:00PM +0530, Aruna Balakrishnaiah wrote:
>> sosreport does not accept commas, period and alphas in the case
>> number, the patch fixes the same.
>>
>> Signed-off-by: Aruna Balakrishnaiah <aruna at linux.vnet.ibm.com>
> This is intentional (it's a number). Why do you want to have commas,
> periods, and alphas in the ticket number field?

In our existing ticket model we use all those chars like 123,7RN,43
so its nice to have this format.

If not, can we atleast have alphas?

Regards,
Aruna
> We also use the dash as a field separator in constructed file and
> directory names so that is also filtered out by the current
> sanitisation.
>
> Regards,
> Bryn.
>
>>       def sanitize_ticket_number(self, ticket_number):
>> -        return re.sub(r"[^0-9]", "", ticket_number)
>> +        return re.sub(r"[^-a-z,A-Z.0-9]", "", ticket_number)