From hegdevasant at linux.vnet.ibm.com Tue Mar 11 05:43:59 2014 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 11 Mar 2014 11:13:59 +0530 Subject: [sos-devel] [PATCH] powerpc: Move VPD related tool under common code Message-ID: <20140311054325.9359.21903.stgit@hegdevasant.in.ibm.com> VPD related tools (lsvpd, lscfg, lsmcode) is supported on both pSeries and PowerNV platform. Hence moving these commands under common code. Also added support to grab vpd database (/var/lib/lsvpd). Signed-off-by: Vasant Hegde --- sos/plugins/powerpc.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py index 41280f3..94ef285 100644 --- a/sos/plugins/powerpc.py +++ b/sos/plugins/powerpc.py @@ -52,14 +52,15 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): self.add_cmd_output("ppc64_cpu --run-mode") self.add_cmd_output("ppc64_cpu --frequency") self.add_cmd_output("ppc64_cpu --dscr") + self.add_cmd_output("lscfg -vp") + self.add_cmd_output("lsmcode -A") + self.add_cmd_output("lsvpd --debug") + self.add_copy_spec("/var/lib/lsvpd/") if ispSeries: self.add_copy_spec("/proc/ppc64/lparcfg") self.add_copy_spec("/proc/ppc64/eeh") self.add_copy_spec("/proc/ppc64/systemcfg") - self.add_cmd_output("lscfg -vp") - self.add_cmd_output("lsmcode -A") - self.add_cmd_output("lsvpd --debug") self.add_cmd_output("lsvio -des") self.add_cmd_output("servicelog --dump") self.add_cmd_output("servicelog_notify --list") From bmr at redhat.com Tue Mar 11 11:09:13 2014 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 11 Mar 2014 11:09:13 +0000 Subject: [sos-devel] [PATCH] powerpc: Move VPD related tool under common code In-Reply-To: <20140311054325.9359.21903.stgit@hegdevasant.in.ibm.com> References: <20140311054325.9359.21903.stgit@hegdevasant.in.ibm.com> Message-ID: <531EEED9.90708@redhat.com> On 03/11/2014 05:43 AM, Vasant Hegde wrote: > VPD related tools (lsvpd, lscfg, lsmcode) is supported on both > pSeries and PowerNV platform. Hence moving these commands under > common code. > > Also added support to grab vpd database (/var/lib/lsvpd). > > Signed-off-by: Vasant Hegde > --- > sos/plugins/powerpc.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied as commit 6fb9d5d - thanks! Regards, Bryn. From hegdevasant at linux.vnet.ibm.com Tue Mar 11 11:38:41 2014 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 11 Mar 2014 17:08:41 +0530 Subject: [sos-devel] [PATCH] powerpc: Collect more debug files for PowerNV platform In-Reply-To: <20140220134512.32490.30630.stgit@hegdevasant.in.ibm.com> References: <20140220134512.32490.30630.stgit@hegdevasant.in.ibm.com> Message-ID: <531EF5C1.50806@linux.vnet.ibm.com> On 02/20/2014 07:15 PM, Vasant Hegde wrote: > This patch adds support to collect more debug files on > PowerNV platform. Hi Bryn, Did you get a chance to look into this patch? -Vasant > > Signed-off-by: Vasant Hegde > --- > sos/plugins/powerpc.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py > index dfaacb9..41280f3 100644 > --- a/sos/plugins/powerpc.py > +++ b/sos/plugins/powerpc.py > @@ -71,4 +71,6 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): > > if isPowerNV: > self.add_copy_spec("/proc/ppc64/") > - > + self.add_copy_spec("/sys/kernel/debug/powerpc/") > + if os.path.isdir("/var/log/dump"): > + self.add_cmd_output("ls -l /var/log/dump") > > _______________________________________________ > sos-devel mailing list > sos-devel at redhat.com > https://www.redhat.com/mailman/listinfo/sos-devel > From bmr at redhat.com Tue Mar 11 12:23:15 2014 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 11 Mar 2014 12:23:15 +0000 Subject: [sos-devel] [PATCH] powerpc: Collect more debug files for PowerNV platform In-Reply-To: <531EF5C1.50806@linux.vnet.ibm.com> References: <20140220134512.32490.30630.stgit@hegdevasant.in.ibm.com> <531EF5C1.50806@linux.vnet.ibm.com> Message-ID: <531F0033.20906@redhat.com> On 03/11/2014 11:38 AM, Vasant Hegde wrote: > On 02/20/2014 07:15 PM, Vasant Hegde wrote: >> This patch adds support to collect more debug files on >> PowerNV platform. > > Hi Bryn, > > Did you get a chance to look into this patch? Hi Vasant, Sorry, this one appears to have slipped through. I've pushed it now as commit a66d4fc (minor tweaks to the commit message and whitespace). Looking at the code we have now in this plugin I see we collect a few bits from /proc/ppc64 for pSeries: if ispSeries: self.add_copy_spec("/proc/ppc64/lparcfg") self.add_copy_spec("/proc/ppc64/eeh") self.add_copy_spec("/proc/ppc64/systemcfg") Whereas PowerNV picks up the whole tree: if isPowerNV: self.add_copy_spec("/proc/ppc64/") Is there really nothing of interest in there for pSeries systems or should we just pick up the whole tree if it's present? Regards, Bryn. From hegdevasant at linux.vnet.ibm.com Tue Mar 11 13:29:47 2014 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 11 Mar 2014 18:59:47 +0530 Subject: [sos-devel] [PATCH] powerpc: Collect more debug files for PowerNV platform In-Reply-To: <531F0033.20906@redhat.com> References: <20140220134512.32490.30630.stgit@hegdevasant.in.ibm.com> <531EF5C1.50806@linux.vnet.ibm.com> <531F0033.20906@redhat.com> Message-ID: <531F0FCB.3010100@linux.vnet.ibm.com> On 03/11/2014 05:53 PM, Bryn M. Reeves wrote: > On 03/11/2014 11:38 AM, Vasant Hegde wrote: >> On 02/20/2014 07:15 PM, Vasant Hegde wrote: >>> This patch adds support to collect more debug files on >>> PowerNV platform. >> >> Hi Bryn, >> >> Did you get a chance to look into this patch? > > Hi Vasant, > > Sorry, this one appears to have slipped through. I've pushed it now as > commit a66d4fc (minor tweaks to the commit message and whitespace). Bryn, Commit looks good.. Thanks for making correction.. > Looking at the code we have now in this plugin I see we collect a few > bits from /proc/ppc64 for pSeries: > > if ispSeries: > self.add_copy_spec("/proc/ppc64/lparcfg") > self.add_copy_spec("/proc/ppc64/eeh") > self.add_copy_spec("/proc/ppc64/systemcfg") > > Whereas PowerNV picks up the whole tree: > > if isPowerNV: > self.add_copy_spec("/proc/ppc64/") > > Is there really nothing of interest in there for pSeries systems or > should we just pick up the whole tree if it's present? Its intentional.. On pSeries /proc/ppc64 contains more files than what we need for debug.. Also some of those files takes longer time to copy. Hence we added only required file.. Whereas in PowerNV /proc/ppc64 contains minimal files which are required .. Hence copying everything.. -Vasant > > Regards, > Bryn. > From bmr at redhat.com Tue Mar 11 13:35:27 2014 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 11 Mar 2014 13:35:27 +0000 Subject: [sos-devel] [PATCH] powerpc: Collect more debug files for PowerNV platform In-Reply-To: <531F0FCB.3010100@linux.vnet.ibm.com> References: <20140220134512.32490.30630.stgit@hegdevasant.in.ibm.com> <531EF5C1.50806@linux.vnet.ibm.com> <531F0033.20906@redhat.com> <531F0FCB.3010100@linux.vnet.ibm.com> Message-ID: <531F111F.3020406@redhat.com> On 03/11/2014 01:29 PM, Vasant Hegde wrote: >> Is there really nothing of interest in there for pSeries systems or >> should we just pick up the whole tree if it's present? > > Its intentional.. On pSeries /proc/ppc64 contains more files than what > we need for debug.. Also some of those files takes longer time to copy. > Hence we added only required file.. > > Whereas in PowerNV /proc/ppc64 contains minimal files which are required > .. Hence copying everything.. Gotcha, makes sense - just wanted to understand the reasoning behind the difference. Regards, Bryn.