[sos-devel] [RESEND PATCH v2] sosreport: Accept commas, period and alphas in the case id

Aruna Balakrishnaiah aruna at linux.vnet.ibm.com
Tue Sep 16 09:19:22 UTC 2014


On Tuesday 16 September 2014 02:47 PM, Bryn M. Reeves wrote:
> On Mon, Sep 15, 2014 at 06:18:57PM +0530, Aruna Balakrishnaiah wrote:
>> sosreport does not accept commas, period and alphas in the case
>> id, the patch fixes the same.
>>
>> Change the ticket number field to case id as it now accepts
>> alpha numerals as well.
> Thanks; I assume this is the version you wanted to submit (although
> it says 'v2' the previous 'v3' had a truncated description).

Yes true, Since it had a truncated description I had to resend it.

>
> The patch currently fails the pep8 test suite:
>
> $ .git/hooks/pre-commit
> checking pep8 conformance
> sos/policies/__init__.py:413:46: E127 continuation line over-indented for visual indent
> pep8: [FAILED]
>
> I'll fix this up for now but in future it's easier if problems like
> this are addressed before submitting (one advantage of using GitHub
> is that you can set up the Travis CI integration checks to run on
> all commits).

Sure will take care of it from next time.

Thanks for accepting the patch!

Regards,
Aruna

>
> Regards,
> Bryn.
>




More information about the sos-devel mailing list