From aruna at linux.vnet.ibm.com Fri Jan 9 06:05:06 2015 From: aruna at linux.vnet.ibm.com (Aruna Balakrishnaiah) Date: Fri, 09 Jan 2015 11:35:06 +0530 Subject: [sos-devel] Fwd: Re: [PATCH] [iprconfig] add plugin for IBM Power RAID adapters In-Reply-To: <54AF6D30.2050907@linux.vnet.ibm.com> References: <54AF6D30.2050907@linux.vnet.ibm.com> Message-ID: <54AF6F92.7070404@linux.vnet.ibm.com> -------- Original Message -------- Subject: Re: [sos-devel] [PATCH] [iprconfig] add plugin for IBM Power RAID adapters Date: Fri, 09 Jan 2015 11:24:56 +0530 From: Aruna Balakrishnaiah To: Bryn M. Reeves Bryn, When can we expect it to be merged? Regards, Aruna On Tuesday 16 December 2014 01:03 PM, Aruna Balakrishnaiah wrote: > > Bryn, > > Tested. Works fine, you can merge. > > Regards, > Aruna > > On Monday 15 December 2014 11:04 PM, Bryn M. Reeves wrote: >> Capture information which helps in better understanding of >> IBM Power RAID storage adapter configuration. Since iprconfig >> is specific to power adding the relevant commands in powerpc plugin. >> >> Signed-off-by: Aruna Balakrishnaiah >> Signed-off-by: Bryn M. Reeves >> --- >> sos/plugins/iprconfig.py | 110 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 110 insertions(+) >> create mode 100644 sos/plugins/iprconfig.py >> >> diff --git a/sos/plugins/iprconfig.py b/sos/plugins/iprconfig.py >> new file mode 100644 >> index 0000000..b77c192 >> --- /dev/null >> +++ b/sos/plugins/iprconfig.py >> @@ -0,0 +1,110 @@ >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 2 of the License, or >> +# (at your option) any later version. >> + >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> + >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write to the Free Software >> +# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. >> + >> +# This plugin enables collection of logs for Power systems >> + >> +import os >> +import re >> +from sos.plugins import Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin >> +from sos.utilities import is_executable >> + >> + >> +class IprConfig(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): >> + """IBM Power RAID storage adapter configuration information >> + """ >> + >> + plugin_name = 'iprconfig' >> + >> + def check_enabled(self): >> + arch = self.policy().get_arch() >> + return arch == "ppc64" and is_executable("iprconfig") >> + >> + def setup(self): >> + self.add_cmd_output([ >> + "iprconfig -c show-config", >> + "iprconfig -c show-alt-config", >> + "iprconfig -c show-arrays", >> + "iprconfig -c show-jbod-disks", >> + "iprconfig -c show-ioas", >> + ]) >> + >> + show_ioas = self.call_ext_prog("iprconfig -c show-ioas") >> + if not show_ioas['status'] == 0: >> + return >> + >> + devices = [] >> + if show_ioas['output']: >> + p = re.compile('sg') >> + for line in show_ioas['output'].splitlines(): >> + temp = line.split(' ') >> + # temp[0] holds the device name >> + if p.search(temp[0]): >> + devices.append(temp[0]) >> + >> + for device in devices: >> + self.add_cmd_output("iprconfig -c show-details %s" % (device,)) >> + >> + # Look for IBM Power RAID enclosures (iprconfig lists them) >> + show_config = self.call_ext_prog("iprconfig -c show-config") >> + if not show_config['status'] == 0: >> + return >> + >> + if not show_config['output']: >> + return >> + >> +# iprconfig -c show-config >> +# Name PCI/SCSI Location Description Status >> +# ------ ------------------------- ------------------------- ----------------- >> +# 0005:60:00.0/0: PCI-E SAS RAID Adapter Operational >> +# sda 0005:60:00.0/0:0:0:0 Physical Disk Active >> +# sdb 0005:60:00.0/0:1:0:0 Physical Disk Active >> +# sdc 0005:60:00.0/0:2:0:0 Physical Disk Active >> +# sdd 0005:60:00.0/0:3:0:0 Physical Disk Active >> +# sde 0005:60:00.0/0:4:0:0 Physical Disk Active >> +# sdf 0005:60:00.0/0:5:0:0 Physical Disk Active >> +# 0005:60:00.0/0:8:0:0 Enclosure Active >> +# 0005:60:00.0/0:8:1:0 Enclosure Active >> + >> + show_alt_config = "iprconfig -c show-alt-config" >> + altconfig = self.call_ext_prog(show_alt_config) >> + if not (altconfig['status'] == 0): >> + return >> + >> + if not altconfig['output']: >> + return >> + >> +# iprconfig -c show-alt-config >> +# Name Resource Path/Address Vendor Product ID Status >> +# ------ -------------------------- -------- ---------------- ----------------- >> +# sg9 0: IBM 57C7001SISIOA Operational >> +# sg0 0:0:0:0 IBM MBF2300RC Active >> +# sg1 0:1:0:0 IBM MBF2300RC Active >> +# sg2 0:2:0:0 IBM HUC106030CSS600 Active >> +# sg3 0:3:0:0 IBM HUC106030CSS600 Active >> +# sg4 0:4:0:0 IBM HUC106030CSS600 Active >> +# sg5 0:5:0:0 IBM HUC106030CSS600 Active >> +# sg7 0:8:0:0 IBM VSBPD6E4A 3GSAS Active >> +# sg8 0:8:1:0 IBM VSBPD6E4B 3GSAS Active >> + >> + for line in show_config['output'].splitlines(): >> + if "Enclosure" in line: >> + temp = re.split('\s+', line) >> + # temp[1] holds the PCI/SCSI location >> + pci, scsi = temp[1].split('/') >> + for line in altconfig['output'].splitlines(): >> + if scsi in line: >> + temp = line.split(' ') >> + # temp[0] holds device name >> + self.add_cmd_output("iprconfig -c " >> + "query-ses-mode %s" % (temp[0],)) > > _______________________________________________ > sos-devel mailing list > sos-devel at redhat.com > https://www.redhat.com/mailman/listinfo/sos-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From john.haxby at oracle.com Tue Jan 13 14:22:22 2015 From: john.haxby at oracle.com (John Haxby) Date: Tue, 13 Jan 2015 14:22:22 +0000 Subject: [sos-devel] plugins/selinux fixfiles options doesn't work as intended Message-ID: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> Hello All, I was investigating selinux-related problems remotely and thought, ah, I remember, sosreport has a fixfiles option for the selinux plugin: sosreport -o selinux -kselinux.fixfiles Imagine my disappointment when the fixfiles output in the sosreport contained one single and not especially useful line: Checking / /boot /dev /dev/hugepages /dev/mqueue /dev/pts /dev/shm /home /run /sys /sys/fs/cgroup If you run sosreport like that what you'll see is a million and one lines warning you that a lot of files don't have a default selinux context and, if you keep your eyes peeled, you'll see some lines reporting the wrong context for some files. The fixfiles script doesn't work the way sosreport expects. Fixfiles writes everything to a log file which, by default, is /dev/tty or /dev/null if there is no tty. The following patch, which I hope you will find useful, replaces "fixfiles check -v" with "restorecon -Rvn 2>/dev/null". For the purposes of sosreport, I don't believe the warnings about no default context for a lot of files are useful which is why stderr is discarded. jch From john.haxby at oracle.com Tue Jan 13 14:22:23 2015 From: john.haxby at oracle.com (John Haxby) Date: Tue, 13 Jan 2015 14:22:23 +0000 Subject: [sos-devel] [PATCH] plugins/selinux: fixfiles produces no useful output, use restorecon In-Reply-To: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> References: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> Message-ID: <1421158943-23914-2-git-send-email-john.haxby@oracle.com> Also discard stderr for restorecon since that just reports files that have no default context which is almost certainly not useful. Signed-off-by: John Haxby --- sos/plugins/selinux.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sos/plugins/selinux.py b/sos/plugins/selinux.py index c914a9b..117ea06 100644 --- a/sos/plugins/selinux.py +++ b/sos/plugins/selinux.py @@ -39,7 +39,7 @@ class SELinux(Plugin, RedHatPlugin): "ps axuZww" ]) if self.get_option('fixfiles'): - self.add_cmd_output("fixfiles -v check") + self.add_cmd_output("restorecon -Rvn / 2>/dev/null") if self.get_option('list'): self.add_cmd_output([ "semanage fcontext -l", -- 1.8.3.1 From bmr at redhat.com Tue Jan 13 14:36:12 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 13 Jan 2015 14:36:12 +0000 Subject: [sos-devel] plugins/selinux fixfiles options doesn't work as intended In-Reply-To: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> References: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> Message-ID: <20150113143610.GB27881@localhost.localdomain> On Tue, Jan 13, 2015 at 02:22:22PM +0000, John Haxby wrote: > Hello All, > > I was investigating selinux-related problems remotely and thought, ah, > I remember, sosreport has a fixfiles option for the selinux plugin: > > sosreport -o selinux -kselinux.fixfiles > > Imagine my disappointment when the fixfiles output in the sosreport > contained one single and not especially useful line: This is because: https://bugzilla.redhat.com/show_bug.cgi?id=955249 I was hoping we might see a fix from the SELinux side (last discussed ~1mo ago) but we've already proposed switching to restorecon due to this problem: https://bugzilla.redhat.com/show_bug.cgi?id=955249#c5 Unfortunately SELinux userspace has quite a few problems of this nature. > The fixfiles script doesn't work the way sosreport expects. Fixfiles > writes everything to a log file which, by default, is /dev/tty or > /dev/null if there is no tty. The following patch, which I hope you > will find useful, replaces "fixfiles check -v" with "restorecon -Rvn > 2>/dev/null". For the purposes of sosreport, I don't believe the > warnings about no default context for a lot of files are useful which > is why stderr is discarded. We know (and actually fixfiles does not work the way its maintainer expects :). Regards, Bryn. From bmr at redhat.com Tue Jan 13 14:43:05 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 13 Jan 2015 14:43:05 +0000 Subject: [sos-devel] [PATCH] plugins/selinux: fixfiles produces no useful output, use restorecon In-Reply-To: <1421158943-23914-2-git-send-email-john.haxby@oracle.com> References: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> <1421158943-23914-2-git-send-email-john.haxby@oracle.com> Message-ID: <20150113144303.GC27881@localhost.localdomain> On Tue, Jan 13, 2015 at 02:22:23PM +0000, John Haxby wrote: > diff --git a/sos/plugins/selinux.py b/sos/plugins/selinux.py > index c914a9b..117ea06 100644 > --- a/sos/plugins/selinux.py > +++ b/sos/plugins/selinux.py > @@ -39,7 +39,7 @@ class SELinux(Plugin, RedHatPlugin): > "ps axuZww" > ]) > if self.get_option('fixfiles'): > - self.add_cmd_output("fixfiles -v check") > + self.add_cmd_output("restorecon -Rvn / 2>/dev/null") We no longer run commands with a shell so the redirect syntax here won't work: commit 46b6c3d39f923d19fa7fcfec96c1cf2d23c768be Author: Bryn M. Reeves Date: Sun Apr 6 18:01:33 2014 +0100 Call Popen with shell=False Fixes Issue #253. Signed-off-by: Bryn M. Reeves Including stderr here shouldn't be a problem (it's trivial to filter on the analysis side) or alternatively a fix for Issue #267 would allow the stderr content to be discarded directly from the Plugin.add_cmd_output() call: https://github.com/sosreport/sos/issues/267 #267 should be a straightforward feature - it's just been low down on the priority list. Regards, Bryn. From john.haxby at oracle.com Tue Jan 13 14:45:22 2015 From: john.haxby at oracle.com (John Haxby) Date: Tue, 13 Jan 2015 14:45:22 +0000 Subject: [sos-devel] [PATCH] plugins/selinux: fixfiles produces no useful output, use restorecon In-Reply-To: <20150113144303.GC27881@localhost.localdomain> References: <1421158943-23914-1-git-send-email-john.haxby@oracle.com> <1421158943-23914-2-git-send-email-john.haxby@oracle.com> <20150113144303.GC27881@localhost.localdomain> Message-ID: <54B52F82.7070809@oracle.com> On 13/01/15 14:43, Bryn M. Reeves wrote: > On Tue, Jan 13, 2015 at 02:22:23PM +0000, John Haxby wrote: >> diff --git a/sos/plugins/selinux.py b/sos/plugins/selinux.py >> index c914a9b..117ea06 100644 >> --- a/sos/plugins/selinux.py >> +++ b/sos/plugins/selinux.py >> @@ -39,7 +39,7 @@ class SELinux(Plugin, RedHatPlugin): >> "ps axuZww" >> ]) >> if self.get_option('fixfiles'): >> - self.add_cmd_output("fixfiles -v check") >> + self.add_cmd_output("restorecon -Rvn / 2>/dev/null") > > We no longer run commands with a shell so the redirect syntax here > won't work: > > commit 46b6c3d39f923d19fa7fcfec96c1cf2d23c768be > Author: Bryn M. Reeves > Date: Sun Apr 6 18:01:33 2014 +0100 > > Call Popen with shell=False > > Fixes Issue #253. > > Signed-off-by: Bryn M. Reeves > > Including stderr here shouldn't be a problem (it's trivial to > filter on the analysis side) or alternatively a fix for Issue #267 > would allow the stderr content to be discarded directly from the > Plugin.add_cmd_output() call: > > https://github.com/sosreport/sos/issues/267 > > #267 should be a straightforward feature - it's just been low down > on the priority list. Ah. OK, I'll look into that and resubmit my patch. jch From michael.kerrin at hp.com Wed Jan 14 12:19:26 2015 From: michael.kerrin at hp.com (Michael Kerrin) Date: Wed, 14 Jan 2015 12:19:26 +0000 Subject: [sos-devel] ignore certain files Message-ID: <13408855.eO8SZ5fBkQ@michael-hp-z400-workstation> Hi all, We use sosreport to collect logs from running openstack systems. So we are using all the openstack_* plugins. Is it possible for me to write a policy or plugin that will ignore certain log files specific to our installations. The add_forbidden_path only keeps a list of forbidden paths on a per plugin bases so how do I tell the openstack_nova plugin to ignore files in /var/log/nova that I don't want to backup. Equally for openstack_neutron, openstack_cinder, etc. Thanks in advance, Michael -------------- next part -------------- An HTML attachment was scrubbed... URL: From john.haxby at oracle.com Mon Jan 19 17:08:41 2015 From: john.haxby at oracle.com (John Haxby) Date: Mon, 19 Jan 2015 17:08:41 +0000 Subject: [sos-devel] v2: plugins/selinux fixfiles options doesn't work as intended Message-ID: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> Hello All, To recap, the fixfiles option for the selinux plugin sends numerous messages (mostly warnings) to the screen and logs just this to the sosreport: Checking / /boot /dev /dev/hugepages /dev/mqueue /dev/pts /dev/shm /home /run /sys /sys/fs/cgroup This is a little less than useful :) The first patch here is in response to https://github.com/sosreport/sos/issues/267 and simply provides a mechanism for discarding stderr when running a command. A Plugin.add_cmd_output() has a new keep_stderr keyword argument whose default value is "True". The second patch changes the fixfiles option for the selinux plugin to use "restorecon -Rvn /" instead of "fixfiles check -v" because the output of the latteer cannot be redirected (the bug for this was recently closed WONTFIX which is perhaps surprising). Having got output that can be redirected, the restorecon stderr is no long kept. I went with "keep_stderr=True" rather than "discard_stderr=False" because I don't like double negatives. Originally, as well, I actually had stderr sent directly to /dev/null, but I decided to go with the simpler option of capturing it and throwing it away. I've at least created a sosreport and including the fixfiles option and everything looks OK but I'm willing to believe (more than willing) tbat I've overlooked something. jch From john.haxby at oracle.com Mon Jan 19 17:08:42 2015 From: john.haxby at oracle.com (John Haxby) Date: Mon, 19 Jan 2015 17:08:42 +0000 Subject: [sos-devel] [PATCH 1/2] Allow commands to discard stderr In-Reply-To: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> References: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> Message-ID: <1421687323-15126-2-git-send-email-john.haxby@oracle.com> Just add "keep_stderr=False" to add_cmd_output() if you don't want the command's stderr in the sosreport. Signed-off-by: John Haxby --- sos/plugins/__init__.py | 29 +++++++++++++++++------------ sos/utilities.py | 5 +++-- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/sos/plugins/__init__.py b/sos/plugins/__init__.py index 4fd85be..12546a4 100644 --- a/sos/plugins/__init__.py +++ b/sos/plugins/__init__.py @@ -460,8 +460,9 @@ class Plugin(object): self.copy_paths.update(copy_paths) self._log_info("added copyspec '%s'" % copyspec) - def get_command_output(self, prog, timeout=300, runat=None): - result = sos_get_command_output(prog, timeout=timeout, runat=runat) + def get_command_output(self, prog, timeout=300, runat=None, keep_stderr=True): + result = sos_get_command_output(prog, timeout=timeout, runat=runat, + keep_stderr=keep_stderr) if result['status'] == 124: self._log_warn("command '%s' timed out after %ds" % (prog, timeout)) @@ -470,11 +471,12 @@ class Plugin(object): self._log_debug("could not run '%s': command not found" % prog) return result - def call_ext_prog(self, prog, timeout=300, runat=None): + def call_ext_prog(self, prog, timeout=300, runat=None, keep_stderr=True): """Execute a command independantly of the output gathering part of sosreport. """ - return self.get_command_output(prog, timeout=timeout, runat=runat) + return self.get_command_output(prog, timeout=timeout, runat=runat, + keep_stderr=True) def check_ext_prog(self, prog): """Execute a command independently of the output gathering part of @@ -484,15 +486,16 @@ class Plugin(object): return self.call_ext_prog(prog)['status'] == 0 def add_cmd_output(self, cmds, suggest_filename=None, - root_symlink=None, timeout=300, runat=None): + root_symlink=None, timeout=300, runat=None, + keep_stderr=True): """Run a program or a list of programs and collect the output""" if isinstance(cmds, six.string_types): cmds = [cmds] if len(cmds) > 1 and (suggest_filename or root_symlink): self._log_warn("ambiguous filename or symlink for command list") for cmd in cmds: - cmdt = (cmd, suggest_filename, root_symlink, timeout, runat) - _logstr = "packed command tuple: ('%s', '%s', '%s', %s, '%s')" + cmdt = (cmd, suggest_filename, root_symlink, timeout, runat, keep_stderr) + _logstr = "packed command tuple: ('%s', '%s', '%s', %s, '%s', '%s')" self._log_debug(_logstr % cmdt) self.collect_cmds.append(cmdt) self._log_info("added cmd output '%s'" % cmd) @@ -547,12 +550,13 @@ class Plugin(object): def get_cmd_output_now(self, exe, suggest_filename=None, root_symlink=False, timeout=300, - runat=None): + runat=None, keep_stderr=True): """Execute a command and save the output to a file for inclusion in the report. """ start = time() - result = self.get_command_output(exe, timeout=timeout, runat=runat) + result = self.get_command_output(exe, timeout=timeout, runat=runat, + keep_stderr=keep_stderr) # 126 means 'found but not executable' if result['status'] == 126 or result['status'] == 127: return None @@ -601,13 +605,14 @@ class Plugin(object): def _collect_cmd_output(self): for progs in zip(self.collect_cmds): - prog, suggest_filename, root_symlink, timeout, runat = progs[0] + prog, suggest_filename, root_symlink, timeout, runat, keep_stderr = progs[0] self._log_debug("unpacked command tuple: " - + "('%s', '%s', '%s', %s, '%s')" % progs[0]) + + "('%s', '%s', '%s', %s, '%s', %s)" % progs[0]) self._log_info("collecting output of '%s'" % prog) self.get_cmd_output_now(prog, suggest_filename=suggest_filename, root_symlink=root_symlink, - timeout=timeout, runat=runat) + timeout=timeout, runat=runat, + keep_stderr=keep_stderr) def _collect_strings(self): for string, file_name in self.copy_strings: diff --git a/sos/utilities.py b/sos/utilities.py index 51909c6..639bc68 100644 --- a/sos/utilities.py +++ b/sos/utilities.py @@ -120,7 +120,7 @@ def is_executable(command): return any(os.access(path, os.X_OK) for path in candidates) -def sos_get_command_output(command, timeout=300, runat=None): +def sos_get_command_output(command, timeout=300, runat=None, keep_stderr=True): """Execute a command through the system shell. First checks to see if the requested command is executable. Returns (returncode, stdout, 0)""" def _child_chdir(): @@ -142,7 +142,8 @@ def sos_get_command_output(command, timeout=300, runat=None): command = command.encode('utf-8', 'ignore') args = shlex.split(command) try: - p = Popen(args, shell=False, stdout=PIPE, stderr=STDOUT, + p = Popen(args, shell=False, stdout=PIPE, + stderr=STDOUT if keep_stderr else PIPE, bufsize=-1, env=cmd_env, close_fds=True, preexec_fn=_child_chdir) except OSError as e: -- 1.8.3.1 From john.haxby at oracle.com Mon Jan 19 17:08:43 2015 From: john.haxby at oracle.com (John Haxby) Date: Mon, 19 Jan 2015 17:08:43 +0000 Subject: [sos-devel] [PATCH 2/2] plugins/selinux: fixfiles produces no useful output, use restorecon In-Reply-To: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> References: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> Message-ID: <1421687323-15126-3-git-send-email-john.haxby@oracle.com> Also discard stderr for restorecon since that just reports files that have no default context which is almost certainly not useful for sos. Signed-off-by: John Haxby --- sos/plugins/selinux.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sos/plugins/selinux.py b/sos/plugins/selinux.py index c914a9b..9d6bb53 100644 --- a/sos/plugins/selinux.py +++ b/sos/plugins/selinux.py @@ -39,7 +39,7 @@ class SELinux(Plugin, RedHatPlugin): "ps axuZww" ]) if self.get_option('fixfiles'): - self.add_cmd_output("fixfiles -v check") + self.add_cmd_output("restorecon -Rvn /", keep_stderr=False) if self.get_option('list'): self.add_cmd_output([ "semanage fcontext -l", -- 1.8.3.1 From notifications at travis-ci.org Mon Jan 19 19:49:43 2015 From: notifications at travis-ci.org (Travis CI) Date: Mon, 19 Jan 2015 19:49:43 +0000 Subject: [sos-devel] Broken: sosreport/sos#655 (master - 8b49485) In-Reply-To: Message-ID: <54bd5fd6c2560_310c1244351557@8adc473c-8ec9-4c97-acbb-832ef7997037.mail> Build Update for sosreport/sos ------------------------------------- Build: #655 Status: Broken Duration: 49 seconds Commit: 8b49485 (master) Author: Bryn M. Reeves Message: [sosreport] log plugin exceptions to a file Add exception logging for the Plugin.postproc() method and move plugin exceptions into a separate per-plugin log file. This is less cluttered than pushing a multi-line traceback through the soslog.error logger and matches the behaviour of older releases. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/12ec2a4643c8...8b49485153cc View the full build log and details: https://travis-ci.org/sosreport/sos/builds/47561121 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Mon Jan 19 19:57:27 2015 From: notifications at travis-ci.org (Travis CI) Date: Mon, 19 Jan 2015 19:57:27 +0000 Subject: [sos-devel] Fixed: sosreport/sos#656 (master - 263e418) In-Reply-To: Message-ID: <54bd61a546cd0_3110436029742d@429399b0-2c16-4664-ac75-8f1c759d4c67.mail> Build Update for sosreport/sos ------------------------------------- Build: #656 Status: Fixed Duration: 31 seconds Commit: 263e418 (master) Author: Bryn M. Reeves Message: [sosreport] fix stray whitespace fix from previous commit Fixed in tree but not added to commit. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/8b49485153cc...263e4183822c View the full build log and details: https://travis-ci.org/sosreport/sos/builds/47561873 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Tue Jan 20 16:16:48 2015 From: notifications at travis-ci.org (Travis CI) Date: Tue, 20 Jan 2015 16:16:48 +0000 Subject: [sos-devel] Passed: sosreport/sos#661 (sbradley-parted_sector_units - f2d9d8d) In-Reply-To: Message-ID: <54be7f6ece0e0_3a5f5ba238787@19566dfb-8c42-4483-b642-e4b50c05b382.mail> Build Update for sosreport/sos ------------------------------------- Build: #661 Status: Passed Duration: 22 seconds Commit: f2d9d8d (sbradley-parted_sector_units) Author: Shane Bradley Message: [block] Don't use parted human readable output - rhbz #1183770 Changed the parted command to return data in sectors units instead of human readable form. Signed-off-by: Shane Bradley View the changeset: https://github.com/sosreport/sos/commit/f2d9d8d04ec2 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/47665716 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Tue Jan 20 16:41:45 2015 From: notifications at travis-ci.org (Travis CI) Date: Tue, 20 Jan 2015 16:41:45 +0000 Subject: [sos-devel] Failed: sosreport/sos#663 (sbradley-puppet-new_plugin - 7998440) In-Reply-To: Message-ID: <54be8549543a8_3b325b42519c1@19566dfb-8c42-4483-b642-e4b50c05b382.mail> Build Update for sosreport/sos ------------------------------------- Build: #663 Status: Failed Duration: 4 minutes and 39 seconds Commit: 7998440 (sbradley-puppet-new_plugin) Author: Shane Bradley Message: [puppet] Adding new plugin for puppet - rhbz #1183768 Added a new plugin to collect files for puppet. Signed-off-by: Shane Bradley View the changeset: https://github.com/sosreport/sos/commit/79984402303b View the full build log and details: https://travis-ci.org/sosreport/sos/builds/47668112 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at travis-ci.org Tue Jan 20 21:28:11 2015 From: notifications at travis-ci.org (Travis CI) Date: Tue, 20 Jan 2015 21:28:11 +0000 Subject: [sos-devel] Passed: sosreport/sos#664 (sbradley-pcp_collect_pcp_conf - c94c8c1) In-Reply-To: Message-ID: <54bec86a5ff28_313a66e24377fa@d0af77a6-95e1-429e-8649-82be75aed104.mail> Build Update for sosreport/sos ------------------------------------- Build: #664 Status: Passed Duration: 1 minute and 52 seconds Commit: c94c8c1 (sbradley-pcp_collect_pcp_conf) Author: Shane Bradley Message: [pcp] Gather /etc/pcp.conf in pcp plugin - rhbz #1183297 The file /etc/pcp.conf is added to list of lists that will be collected. Signed-off-by: Shane Bradley View the changeset: https://github.com/sosreport/sos/commit/c94c8c16c7d8 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/47702938 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Fri Jan 23 17:15:19 2015 From: builds at travis-ci.org (Travis CI) Date: Fri, 23 Jan 2015 17:15:19 +0000 Subject: [sos-devel] Fixed: sosreport/sos#669 (sbradley-puppet-new_plugin - c927213) In-Reply-To: Message-ID: <54c281a6470b8_3b6200426829a@b7477d58-7a08-4e56-8f4c-f51d7377bfea.mail> Build Update for sosreport/sos ------------------------------------- Build: #669 Status: Fixed Duration: 31 seconds Commit: c927213 (sbradley-puppet-new_plugin) Author: Shane Bradley Message: [puppet] Removed some newlines that was causing pep8 to fail. Signed-off-by: Shane Bradley View the changeset: https://github.com/sosreport/sos/compare/79984402303b...c927213f24cb View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48077133 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sat Jan 24 00:37:54 2015 From: builds at travis-ci.org (Travis CI) Date: Sat, 24 Jan 2015 00:37:54 +0000 Subject: [sos-devel] Passed: sosreport/sos#671 (bmr-tupperware - b9fa2cd) In-Reply-To: Message-ID: <54c2e96220b70_317dd4ba5012a3@b7477d58-7a08-4e56-8f4c-f51d7377bfea.mail> Build Update for sosreport/sos ------------------------------------- Build: #671 Status: Passed Duration: 31 seconds Commit: b9fa2cd (bmr-tupperware) Author: Bryn M. Reeves Message: [docs] add -s/--sysroot to sosreport.1 Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/f8847f83aec6^...b9fa2cdf1e83 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48125386 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 14:23:44 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 14:23:44 +0000 Subject: [sos-devel] Errored: sosreport/sos#674 (bmr-tupperware - 33339e1) In-Reply-To: Message-ID: <54c4fc706a338_32d53189155a@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #674 Status: Errored Duration: 49 seconds Commit: 33339e1 (bmr-tupperware) Author: Bryn M. Reeves Message: [utilities] add chroot support to sos_get_command_output() Allow callers of sos_get_command_output() to specify a path to chroot into before executing command. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/91cc6bb91182...33339e1aa263 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48246311 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 14:24:33 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 14:24:33 +0000 Subject: [sos-devel] Broken: sosreport/sos#675 (bmr-tupperware - 3b215e5) In-Reply-To: Message-ID: <54c4fca17c448_3b15a4e2136c9@a933d16f-bbeb-4975-bb78-02f69fe0b913.mail> Build Update for sosreport/sos ------------------------------------- Build: #675 Status: Broken Duration: 34 seconds Commit: 3b215e5 (bmr-tupperware) Author: Bryn M. Reeves Message: [utilities] add chroot support to sos_get_command_output() Allow callers of sos_get_command_output() to specify a path to chroot into before executing command. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/33339e1aa263...3b215e5c7a79 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48246393 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 14:34:06 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 14:34:06 +0000 Subject: [sos-devel] Errored: sosreport/sos#676 (bmr-tupperware - adceb2a) In-Reply-To: Message-ID: <54c4fede6fd10_32fe82894761@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #676 Status: Errored Duration: 25 seconds Commit: adceb2a (bmr-tupperware) Author: Bryn M. Reeves Message: [sosreport] add --chroot option Add a --chroot option to sosreport to control command chrooting. The option takes one of three values: * auto - Allow callers of the API to control chroot behaviour * always - Always chroot external commands to --sysroot * never - Never chroot external commands This is a fairly low-level option and may not be exposed to the user in a final release; for now it allows testing in container environments to control the chrooting behaviour used for a run. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/3b215e5c7a79...adceb2aa9ef3 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48246973 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 14:35:15 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 14:35:15 +0000 Subject: [sos-devel] Still Failing: sosreport/sos#677 (bmr-tupperware - 4731f68) In-Reply-To: Message-ID: <54c4ff224f970_33047909539d@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #677 Status: Still Failing Duration: 49 seconds Commit: 4731f68 (bmr-tupperware) Author: Bryn M. Reeves Message: [sosreport] add --chroot option Add a --chroot option to sosreport to control command chrooting. The option takes one of three values: * auto - Allow callers of the API to control chroot behaviour * always - Always chroot external commands to --sysroot * never - Never chroot external commands This is a fairly low-level option and may not be exposed to the user in a final release; for now it will allow tests in container environments to control the chrooting behaviour used for a run. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/adceb2aa9ef3...4731f68d3bfc View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48247030 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 14:58:46 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 14:58:46 +0000 Subject: [sos-devel] Still Failing: sosreport/sos#678 (bmr-tupperware - d2a5f36) In-Reply-To: Message-ID: <54c504a5cf468_3bbab8e224635@a933d16f-bbeb-4975-bb78-02f69fe0b913.mail> Build Update for sosreport/sos ------------------------------------- Build: #678 Status: Still Failing Duration: 28 seconds Commit: d2a5f36 (bmr-tupperware) Author: Bryn M. Reeves Message: [sosreport] add --chroot option Add a --chroot option to sosreport to control command chrooting. The option takes one of three values: * auto - Allow callers of the API to control chroot behaviour * always - Always chroot external commands to --sysroot * never - Never chroot external commands This is a fairly low-level option and may not be exposed to the user in a final release; for now it will allow tests in container environments to control the chrooting behaviour used for a run. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/4731f68d3bfc...d2a5f36307db View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48248612 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 15:09:40 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 15:09:40 +0000 Subject: [sos-devel] Fixed: sosreport/sos#679 (bmr-tupperware - e064709) In-Reply-To: Message-ID: <54c507342f1e8_33af124106988@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #679 Status: Fixed Duration: 57 seconds Commit: e064709 (bmr-tupperware) Author: Bryn M. Reeves Message: [packaging] bump release for build sos-3.2-17.el7.atomic Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/d2a5f36307db...e06470963fd3 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48249342 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 19:07:50 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 19:07:50 +0000 Subject: [sos-devel] Broken: sosreport/sos#681 (bmr-tupperware - 1b9fa27) In-Reply-To: Message-ID: <54c53f0572420_37e90c2186530@05ccdae2-4d5e-4f83-9494-0dc64ad45596.mail> Build Update for sosreport/sos ------------------------------------- Build: #681 Status: Broken Duration: 26 seconds Commit: 1b9fa27 (bmr-tupperware) Author: Bryn M. Reeves Message: [travis] test on python2.6 View the changeset: https://github.com/sosreport/sos/compare/3d933cb03bb7...1b9fa276ee89 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48267101 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 19:11:20 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 19:11:20 +0000 Subject: [sos-devel] Fixed: sosreport/sos#682 (bmr-tupperware - 3d933cb) In-Reply-To: Message-ID: <54c53fd85cc60_310c0de43162c8@a933d16f-bbeb-4975-bb78-02f69fe0b913.mail> Build Update for sosreport/sos ------------------------------------- Build: #682 Status: Fixed Duration: 41 seconds Commit: 3d933cb (bmr-tupperware) Author: Bryn M. Reeves Message: [tests] fix test_output_chdir() The Travis environment does not have pwd (coreutils). Try to echo $PWD from a shell instead. If that fails in travis, try: python -c 'import os; print(os.getcwd())' Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/1b9fa276ee89...3d933cb03bb7 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48267336 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 21:56:13 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 21:56:13 +0000 Subject: [sos-devel] Broken: sosreport/sos#684 (bmr-tupperware - f29d1e1) In-Reply-To: Message-ID: <54c5667ce4840_3c1fd5e25994f@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #684 Status: Broken Duration: 24 seconds Commit: f29d1e1 (bmr-tupperware) Author: Bryn M. Reeves Message: [sosreport] check for valid CHROOT values Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/4c1de1f0feb8...f29d1e11262a View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48281046 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Sun Jan 25 23:02:43 2015 From: builds at travis-ci.org (Travis CI) Date: Sun, 25 Jan 2015 23:02:43 +0000 Subject: [sos-devel] Fixed: sosreport/sos#685 (bmr-tupperware - 3b9daa8) In-Reply-To: Message-ID: <54c57613a6fe0_3da0d8c2947b5@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #685 Status: Fixed Duration: 23 seconds Commit: 3b9daa8 (bmr-tupperware) Author: Bryn M. Reeves Message: [sosreport] check for valid CHROOT values Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/f29d1e11262a...3b9daa814ed8 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48286704 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Mon Jan 26 10:42:41 2015 From: builds at travis-ci.org (Travis CI) Date: Mon, 26 Jan 2015 10:42:41 +0000 Subject: [sos-devel] Errored: sosreport/sos#689 (bmr-tupperware - c1bd13b) In-Reply-To: Message-ID: <54c61a2139210_318eedd45233d6@c2e2503b-adf7-43ea-8022-0b0f122b34c5.mail> Build Update for sosreport/sos ------------------------------------- Build: #689 Status: Errored Duration: 18 seconds Commit: c1bd13b (bmr-tupperware) Author: Bryn M. Reeves Message: [packaging] bump release for build sos-3.2-18.el7.atomic - [lvm2] don't chroot if tmp is not inside sysroot - [logs] fix do_regex_find_all() use for --sysroot - [libvirt] use join_sysroot() before calling os.path.exists - [foreman] don't chroot if tmp is not inside sysroot - [dmraid] don't chroot if tmp is not inside sysroot - [cluster] handle crm_report with --sysroot - [plugin] enforce forbidden paths when --sysroot is set - [plugin] add tmp_in_sysroot() method - [plugins] add chroot parameter to callout APIs - [sosreport] check for valid CHROOT values - [plugin] fix chrooted symlink handling - [sosreport] improve --chroot help text Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/b376eaa4db12...c1bd13bd2ea8 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48326802 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Mon Jan 26 14:59:16 2015 From: builds at travis-ci.org (Travis CI) Date: Mon, 26 Jan 2015 14:59:16 +0000 Subject: [sos-devel] Broken: sosreport/sos#691 (bmr-tupperware - a668851) In-Reply-To: Message-ID: <54c65643a4100_33a1a36147962@17d8ebd7-e6af-48b1-91e2-fde800a22390.mail> Build Update for sosreport/sos ------------------------------------- Build: #691 Status: Broken Duration: 32 seconds Commit: a668851 (bmr-tupperware) Author: Bryn M. Reeves Message: [plugin] handle ELOOP in _copy_dir() A problem with systemd's management of the binfmt_misc automount point in Atomic environments causes attempts to access this path to fail with ELOOP: >>> import os >>> os.listdir("/host/proc/sys/fs/binfmt_misc/") Traceback (most recent call last): File "", line 1, in OSError: [Errno 2] No such file or directory: '/host/proc/sys/fs/binfmt_misc/' For reasons that are not yet clear this causes the entire sos process to immediately terminate. For now avoid the problem by enclosing the problem os.listdir in a try/except block that explicitly handles the one errno value implicated here. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/7d0ad58c772c...a668851b6201 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48351086 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Mon Jan 26 15:10:36 2015 From: builds at travis-ci.org (Travis CI) Date: Mon, 26 Jan 2015 15:10:36 +0000 Subject: [sos-devel] Fixed: sosreport/sos#692 (bmr-tupperware - 5cee9ce) In-Reply-To: Message-ID: <54c658ebe38a0_33f62bc153141@17d8ebd7-e6af-48b1-91e2-fde800a22390.mail> Build Update for sosreport/sos ------------------------------------- Build: #692 Status: Fixed Duration: 1 minute and 46 seconds Commit: 5cee9ce (bmr-tupperware) Author: Neependra Khare Message: [kubernetes] new plugin Add a plugin for Kubernetes support. Signed-off-by: Neependra Khare Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/a668851b6201...5cee9ce0170c View the full build log and details: https://travis-ci.org/sosreport/sos/builds/48352284 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From hegdevasant at linux.vnet.ibm.com Tue Jan 27 06:32:26 2015 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 27 Jan 2015 12:02:26 +0530 Subject: [sos-devel] [PATCH v4] sosreport: Check for rpm database corruption during initialization In-Reply-To: <20141215124525.GB20130@localhost.localdomain> References: <20141212053729.27655.50568.stgit@aruna-ThinkPad-T420> <20141215124525.GB20130@localhost.localdomain> Message-ID: <54C730FA.3040809@linux.vnet.ibm.com> On 12/15/2014 06:15 PM, Bryn M. Reeves wrote: > On Fri, Dec 12, 2014 at 11:27:07AM +0530, Aruna Balakrishnaiah wrote: >> sosreport runs an rpm query to get the package list. If rpmdb is corrupted >> sosreport hangs for ever hence check for rpmdb consistency before running >> the rpm query Bryn, > > Thanks Aruna, this looks good. The only remaining question I think is how > long the timeout should be; I'll merge it with the current setting but in > most of my tests this operation completes in <30s (actually the vast > majority it's <5s - typically 1-2s). > [ Aruna (author of this patch) left IBM recently and I'm going to take care of outstading patches ] I look into upstream sos and looks like this one is not yet merge.. Can you please look into this one ? -Vasant From hegdevasant at linux.vnet.ibm.com Tue Jan 27 07:41:49 2015 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 27 Jan 2015 13:11:49 +0530 Subject: [sos-devel] [PATCH] [iprconfig] add plugin for IBM Power RAID adapters In-Reply-To: <548FE04F.70504@linux.vnet.ibm.com> References: <20141016110015.11503.22082.stgit@aruna-ThinkPad-T420> <545AFF77.70607@linux.vnet.ibm.com> <20141215173423.GB31314@localhost.localdomain> <548FE04F.70504@linux.vnet.ibm.com> Message-ID: <54C7413D.3080903@linux.vnet.ibm.com> On 12/16/2014 01:03 PM, Aruna Balakrishnaiah wrote: > > Bryn, > > Tested. Works fine, you can merge. Bryn, Did you merge this one ? I don't see this in upstream sos..(https://github.com/sosreport/sos) -Vasant > > Regards, > Aruna > > On Monday 15 December 2014 11:04 PM, Bryn M. Reeves wrote: >> Capture information which helps in better understanding of >> IBM Power RAID storage adapter configuration. Since iprconfig >> is specific to power adding the relevant commands in powerpc plugin. >> >> Signed-off-by: Aruna Balakrishnaiah >> Signed-off-by: Bryn M. Reeves >> --- >> sos/plugins/iprconfig.py | 110 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 110 insertions(+) >> create mode 100644 sos/plugins/iprconfig.py >> >> diff --git a/sos/plugins/iprconfig.py b/sos/plugins/iprconfig.py >> new file mode 100644 >> index 0000000..b77c192 >> --- /dev/null >> +++ b/sos/plugins/iprconfig.py >> @@ -0,0 +1,110 @@ >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 2 of the License, or >> +# (at your option) any later version. >> + >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> + >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write to the Free Software >> +# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. >> + >> +# This plugin enables collection of logs for Power systems >> + >> +import os >> +import re >> +from sos.plugins import Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin >> +from sos.utilities import is_executable >> + >> + >> +class IprConfig(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): >> + """IBM Power RAID storage adapter configuration information >> + """ >> + >> + plugin_name = 'iprconfig' >> + >> + def check_enabled(self): >> + arch = self.policy().get_arch() >> + return arch == "ppc64" and is_executable("iprconfig") >> + >> + def setup(self): >> + self.add_cmd_output([ >> + "iprconfig -c show-config", >> + "iprconfig -c show-alt-config", >> + "iprconfig -c show-arrays", >> + "iprconfig -c show-jbod-disks", >> + "iprconfig -c show-ioas", >> + ]) >> + >> + show_ioas = self.call_ext_prog("iprconfig -c show-ioas") >> + if not show_ioas['status'] == 0: >> + return >> + >> + devices = [] >> + if show_ioas['output']: >> + p = re.compile('sg') >> + for line in show_ioas['output'].splitlines(): >> + temp = line.split(' ') >> + # temp[0] holds the device name >> + if p.search(temp[0]): >> + devices.append(temp[0]) >> + >> + for device in devices: >> + self.add_cmd_output("iprconfig -c show-details %s" % (device,)) >> + >> + # Look for IBM Power RAID enclosures (iprconfig lists them) >> + show_config = self.call_ext_prog("iprconfig -c show-config") >> + if not show_config['status'] == 0: >> + return >> + >> + if not show_config['output']: >> + return >> + >> +# iprconfig -c show-config >> +# Name PCI/SCSI Location Description Status >> +# ------ ------------------------- ------------------------- ----------------- >> +# 0005:60:00.0/0: PCI-E SAS RAID Adapter Operational >> +# sda 0005:60:00.0/0:0:0:0 Physical Disk Active >> +# sdb 0005:60:00.0/0:1:0:0 Physical Disk Active >> +# sdc 0005:60:00.0/0:2:0:0 Physical Disk Active >> +# sdd 0005:60:00.0/0:3:0:0 Physical Disk Active >> +# sde 0005:60:00.0/0:4:0:0 Physical Disk Active >> +# sdf 0005:60:00.0/0:5:0:0 Physical Disk Active >> +# 0005:60:00.0/0:8:0:0 Enclosure Active >> +# 0005:60:00.0/0:8:1:0 Enclosure Active >> + >> + show_alt_config = "iprconfig -c show-alt-config" >> + altconfig = self.call_ext_prog(show_alt_config) >> + if not (altconfig['status'] == 0): >> + return >> + >> + if not altconfig['output']: >> + return >> + >> +# iprconfig -c show-alt-config >> +# Name Resource Path/Address Vendor Product ID Status >> +# ------ -------------------------- -------- ---------------- ----------------- >> +# sg9 0: IBM 57C7001SISIOA Operational >> +# sg0 0:0:0:0 IBM MBF2300RC Active >> +# sg1 0:1:0:0 IBM MBF2300RC Active >> +# sg2 0:2:0:0 IBM HUC106030CSS600 Active >> +# sg3 0:3:0:0 IBM HUC106030CSS600 Active >> +# sg4 0:4:0:0 IBM HUC106030CSS600 Active >> +# sg5 0:5:0:0 IBM HUC106030CSS600 Active >> +# sg7 0:8:0:0 IBM VSBPD6E4A 3GSAS Active >> +# sg8 0:8:1:0 IBM VSBPD6E4B 3GSAS Active >> + >> + for line in show_config['output'].splitlines(): >> + if "Enclosure" in line: >> + temp = re.split('\s+', line) >> + # temp[1] holds the PCI/SCSI location >> + pci, scsi = temp[1].split('/') >> + for line in altconfig['output'].splitlines(): >> + if scsi in line: >> + temp = line.split(' ') >> + # temp[0] holds device name >> + self.add_cmd_output("iprconfig -c " >> + "query-ses-mode %s" % (temp[0],)) > > _______________________________________________ > sos-devel mailing list > sos-devel at redhat.com > https://www.redhat.com/mailman/listinfo/sos-devel > From bmr at redhat.com Tue Jan 27 10:48:11 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 27 Jan 2015 10:48:11 +0000 Subject: [sos-devel] [PATCH] [iprconfig] add plugin for IBM Power RAID adapters In-Reply-To: <54C7413D.3080903@linux.vnet.ibm.com> References: <20141016110015.11503.22082.stgit@aruna-ThinkPad-T420> <545AFF77.70607@linux.vnet.ibm.com> <20141215173423.GB31314@localhost.localdomain> <548FE04F.70504@linux.vnet.ibm.com> <54C7413D.3080903@linux.vnet.ibm.com> Message-ID: <20150127104810.GA25531@localhost.localdomain> On Tue, Jan 27, 2015 at 01:11:49PM +0530, Vasant Hegde wrote: > On 12/16/2014 01:03 PM, Aruna Balakrishnaiah wrote: > > > > Bryn, > > > > Tested. Works fine, you can merge. > > Bryn, > > Did you merge this one ? I don't see this in upstream > sos..(https://github.com/sosreport/sos) Not yet - it's queued for the next batch of merges - I'm a bit behind pulling these in as I've been tied up with some new feature work. I should get this in this week. Regards, Bryn. From hegdevasant at linux.vnet.ibm.com Tue Jan 27 10:59:34 2015 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 27 Jan 2015 16:29:34 +0530 Subject: [sos-devel] [PATCH] [iprconfig] add plugin for IBM Power RAID adapters In-Reply-To: <20150127104810.GA25531@localhost.localdomain> References: <20141016110015.11503.22082.stgit@aruna-ThinkPad-T420> <545AFF77.70607@linux.vnet.ibm.com> <20141215173423.GB31314@localhost.localdomain> <548FE04F.70504@linux.vnet.ibm.com> <54C7413D.3080903@linux.vnet.ibm.com> <20150127104810.GA25531@localhost.localdomain> Message-ID: <54C76F96.7010300@linux.vnet.ibm.com> On 01/27/2015 04:18 PM, Bryn M. Reeves wrote: > On Tue, Jan 27, 2015 at 01:11:49PM +0530, Vasant Hegde wrote: >> On 12/16/2014 01:03 PM, Aruna Balakrishnaiah wrote: >>> >>> Bryn, >>> >>> Tested. Works fine, you can merge. >> >> Bryn, >> >> Did you merge this one ? I don't see this in upstream >> sos..(https://github.com/sosreport/sos) > > Not yet - it's queued for the next batch of merges - I'm a bit behind > pulling these in as I've been tied up with some new feature work. > > I should get this in this week. Thanks Bryn. -Vasant From bmr at redhat.com Tue Jan 27 12:50:57 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 27 Jan 2015 12:50:57 +0000 Subject: [sos-devel] Fwd: Re: [PATCH] [iprconfig] add plugin for IBM Power RAID adapters In-Reply-To: <54AF6F92.7070404@linux.vnet.ibm.com> References: <54AF6D30.2050907@linux.vnet.ibm.com> <54AF6F92.7070404@linux.vnet.ibm.com> Message-ID: <20150127125056.GC25531@localhost.localdomain> On Fri, Jan 09, 2015 at 11:35:06AM +0530, Aruna Balakrishnaiah wrote: > On Tuesday 16 December 2014 01:03 PM, Aruna Balakrishnaiah wrote: > >Tested. Works fine, you can merge. Applied, thanks! Regards, Bryn. From bmr at redhat.com Tue Jan 27 13:12:06 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Tue, 27 Jan 2015 13:12:06 +0000 Subject: [sos-devel] [PATCH v4] sosreport: Check for rpm database corruption during initialization In-Reply-To: <54C730FA.3040809@linux.vnet.ibm.com> References: <20141212053729.27655.50568.stgit@aruna-ThinkPad-T420> <20141215124525.GB20130@localhost.localdomain> <54C730FA.3040809@linux.vnet.ibm.com> Message-ID: <20150127131206.GD25531@localhost.localdomain> On Tue, Jan 27, 2015 at 12:02:26PM +0530, Vasant Hegde wrote: > On 12/15/2014 06:15 PM, Bryn M. Reeves wrote: > > On Fri, Dec 12, 2014 at 11:27:07AM +0530, Aruna Balakrishnaiah wrote: > >> sosreport runs an rpm query to get the package list. If rpmdb is corrupted > >> sosreport hangs for ever hence check for rpmdb consistency before running > >> the rpm query > > Bryn, > > > > > > Thanks Aruna, this looks good. The only remaining question I think is how > > long the timeout should be; I'll merge it with the current setting but in > > most of my tests this operation completes in <30s (actually the vast > > majority it's <5s - typically 1-2s). > > > > [ Aruna (author of this patch) left IBM recently and I'm going to take care of > outstading > patches ] > > I look into upstream sos and looks like this one is not yet merge.. > > Can you please look into this one ? Applied, thanks! Regards, Bryn. From bmr at redhat.com Wed Jan 28 18:57:12 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Wed, 28 Jan 2015 18:57:12 +0000 Subject: [sos-devel] [networking] add ethtool -d in networking plugin In-Reply-To: <540FE2F7.3060302@linux.vnet.ibm.com> References: <53B37852.5000003@linux.vnet.ibm.com> <53BD027E.4050106@linux.vnet.ibm.com> <20140709111913.GB32673@localhost.localdomain> <540FE2F7.3060302@linux.vnet.ibm.com> Message-ID: <20150128185711.GA25806@localhost.localdomain> On Wed, Sep 10, 2014 at 01:34:47PM +0800, Sheng Liu wrote: > the user wanted to confirm some bug .Capturing the grcDump using the > 'ethtoold -d' command would allow them to make that confirmation. > Another method to capture the grcDump is through the NetXtreme II eDiag > Diagnostic Utility. However, this utility could not to be used by > customers. I've merged this for now (with a slightly different commit message): [networking] add ethtool -d Add 'ethtool -d ' to the networking plugin. This retrieves and prints a register dump for the specified network device. This may be required to debug some low-level network interface problems (e.g. embedded card configuration values) that would otherwise require the use of proprietary diagnostic tools. Signed-off-by: Sheng Liu Signed-off-by: Bryn M. Reeves I spoke to a couple of network driver engineers and the feeling was that this should be reasonably safe; we'll keep an eye out for problems with the command before the next release. Regards, Bryn. From bmr at redhat.com Wed Jan 28 19:49:56 2015 From: bmr at redhat.com (Bryn M. Reeves) Date: Wed, 28 Jan 2015 19:49:56 +0000 Subject: [sos-devel] v2: plugins/selinux fixfiles options doesn't work as intended In-Reply-To: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> References: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> Message-ID: <20150128194956.GB25806@localhost.localdomain> On Mon, Jan 19, 2015 at 05:08:41PM +0000, John Haxby wrote: > I went with "keep_stderr=True" rather than "discard_stderr=False" because I > don't like double negatives. Originally, as well, I actually had stderr sent > directly to /dev/null, but I decided to go with the simpler option of > capturing it and throwing it away. > > I've at least created a sosreport and including the fixfiles option and > everything looks OK but I'm willing to believe (more than willing) tbat I've > overlooked something. Hi John, Thanks very much for working on this and sorry for the delay in getting this reviewed and merged. I've been tied up with other project work since the Christmas break and haven't been able to get to the patch backlog. I've merged these now with a couple of minor tweaks for pep8 conformance (shortening lines) and to shorten the name of the argument to 'stderr': https://github.com/sosreport/sos/commit/7b28857 https://github.com/sosreport/sos/commit/476b7bc As well as helping to keep the size of the command tuple down this means we can extend the interface in future to e.g. allow capturing stderr separately without having to rename it. Regards, Bryn. From john.haxby at oracle.com Wed Jan 28 20:56:59 2015 From: john.haxby at oracle.com (John Haxby) Date: Wed, 28 Jan 2015 20:56:59 +0000 Subject: [sos-devel] v2: plugins/selinux fixfiles options doesn't work as intended In-Reply-To: <20150128194956.GB25806@localhost.localdomain> References: <1421687323-15126-1-git-send-email-john.haxby@oracle.com> <20150128194956.GB25806@localhost.localdomain> Message-ID: > On 28 Jan 2015, at 19:49, Bryn M. Reeves wrote: > > On Mon, Jan 19, 2015 at 05:08:41PM +0000, John Haxby wrote: >> I went with "keep_stderr=True" rather than "discard_stderr=False" because I >> don't like double negatives. Originally, as well, I actually had stderr sent >> directly to /dev/null, but I decided to go with the simpler option of >> capturing it and throwing it away. >> >> I've at least created a sosreport and including the fixfiles option and >> everything looks OK but I'm willing to believe (more than willing) tbat I've >> overlooked something. > > Hi John, > > Thanks very much for working on this and sorry for the delay in getting this > reviewed and merged. I've been tied up with other project work since the > Christmas break and haven't been able to get to the patch backlog. > > I've merged these now with a couple of minor tweaks for pep8 conformance > (shortening lines) and to shorten the name of the argument to 'stderr': > > https://github.com/sosreport/sos/commit/7b28857 > https://github.com/sosreport/sos/commit/476b7bc > > As well as helping to keep the size of the command tuple down this means > we can extend the interface in future to e.g. allow capturing stderr > separately without having to rename it. > > Regards, > Bryn. > Many thanks Bryn. jch -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 236 bytes Desc: Message signed with OpenPGP using GPGMail URL: