[sos-devel] [RFC PATCH] Add IBM PowerKVM policy

[Kamalesh Babulal]

On 07/03/2015 04:58 PM, Bryn M. Reeves wrote:
> On Tue, May 26, 2015 at 03:21:20PM +0530, Kamalesh Babulal wrote:
>> Add support for IBM PowerKVM/ZKVM platform, by introducing
>> PowerKVM/ZKVM policy. It defines PowerKVM/ZKVM specific
>> details/environment, for sos to validate the environment
>> and enable plugins to collect information while running over
>> PowerKVM/ZKVM. Patch also introduces PowerKVM/ZKVM plugin
>> classes which could be used by plugins, when we add support
>> for them individually later.
>>
>> Signed-off-by: Kamalesh Babulal <kamalesh at linux.vnet.ibm.com>
>> Cc: Bryn M. Reeves <bmr at redhat.com>
> Thanks! The policy looks good - there are a couple of pep8 errors in
> the patch though:
>
> checking pep8 conformance
> sos/policies/ibmkvm.py:4:1: E265 block comment should start with '# '
> sos/policies/ibmkvm.py:27:1: E302 expected 2 blank lines, found 1
> sos/policies/ibmkvm.py:45:43: E703 statement ends with a semicolon
> sos/policies/ibmkvm.py:51:1: E302 expected 2 blank lines, found 1
> sos/policies/ibmkvm.py:69:43: E703 statement ends with a semicolon
> sos/policies/ibmkvm.py:70:48: E231 missing whitespace after ','
> sos/plugins/__init__.py:749:80: E501 line too long (82 > 79 characters)
> pep8: [FAILED]
>
> I'll fix these up before I commit but this should get merged today.
>
>

Thanks for fixing them.

-- 
Cheers,
Kamalesh.