[sos-devel] [RESEND PATCH] Fix vim tags typo in all python source files

Bryn M. Reeves bmr at redhat.com
Mon Jul 6 12:32:22 UTC 2015


On Wed, May 27, 2015 at 01:29:26PM +0530, Kamalesh Babulal wrote:
> Fix the spelling of 'set' in vim tags, in all of the
> python sources files.

Hi Kamalesh,
 
> -# vim: et ts=4 sw=4
> +# vim: set ts=4 sw=4

I don't think this is quite correct; this discards the 'et' command that
enables tab-expansion (conversion of tab characters to a corresponding
number of spaces).

The 'et' is not a mis-spelling of 'set'; there are just two ways to do
vim modelines (although not all versions are compatible with every line
format).

I'm also unsure that this makes a valid modeline since it does not end
with a ':' - this is required for the styles which use the 'set'
keyword:

  http://vimdoc.sourceforge.net/htmldoc/options.html#modeline

I've edited the patch so that the final modeline will be:

# vim: set et ts=4 sw=4 :

I think this gives us the options that we want and is compatible with
the widest range of vi and vim variants.

Thanks again for taking this on!

Regards,
Bryn.




More information about the sos-devel mailing list