[sos-devel] [PATCH V2] plugin/ipmitool : Add usb interface if available instead of using default interface

[Mukesh Ojha]

Oops!! My bad .

i missed it to remove, will send it after removing.

-Mukesh


On Friday 02 December 2016 04:39 PM, Bryn M. Reeves wrote:
> On Thu, Dec 01, 2016 at 11:02:00PM +0530, Mukesh Ojha wrote:
>> +import subprocess
>>   from sos.plugins import Plugin, RedHatPlugin, DebianPlugin
> No need to import subprocess if we're using a Plugin API.
>
>> @@ -26,14 +27,22 @@ class IpmiTool(Plugin, RedHatPlugin, DebianPlugin):
>>       packages = ('ipmitool',)
>>   
>>       def setup(self):
>> +        result = self.get_command_output("ipmitool -I usb mc info")
>> +        have_usbintf = result['status']
>> +
>> +        if not have_usbintf:
>> +            cmd = "ipmitool -I usb"
>> +        else:
>> +            cmd = "ipmitool"
>> +
>>           self.add_cmd_output([
>> -            "ipmitool sel info",
>> -            "ipmitool sel list",
>> -            "ipmitool sensor list",
>> -            "ipmitool chassis status",
>> -            "ipmitool fru print",
>> -            "ipmitool mc info",
>> -            "ipmitool sdr info"
>> +            "%s sel info" % cmd,
>> +            "%s sel list" % cmd,
>> +            "%s sensor list" % cmd,
>> +            "%s chassis status" % cmd,
>> +            "%s fru print" % cmd,
>> +            "%s mc info" % cmd,
>> +            "%s sdr info" % cmd
>>           ])
>>   
> Ack to the rest - if you send an updated patch without the subprocess
> import I'll add it to the next round of merges.
>
> Regards,
> Bryn.
>