[sos-devel] [PATCH] [ipmi] Fix ipmitool options

[Vasant Hegde]

On 04/14/2016 04:19 PM, Vasant Hegde wrote:
> As per ipmitool man page 'bmc' option is deprecreated. Instead use 'mc'
> option to get BMC information.
>


Hello Bryn,

Any thoughts on this patch?

-Vasant

> Also we don't have 'sel log' option. Use 'sel list' option to get SEL log
> information.
>
> sample output:
>
> #ipmitool mc info:
> Device ID                 : 32
> Device Revision           : 1
> Firmware Revision         : 2.13
> IPMI Version              : 2.0
> Manufacturer ID           : 0
> Manufacturer Name         : Unknown
> Product ID                : 43707 (0xaabb)
> 	Product Name              : Unknown (0xAABB)
> 	Device Available          : yes
> 	Provides Device SDRs      : no
> ...
> ...
>
> #ipmitool sel list
> 1 | 03/28/2016 | 11:22:10 | System Firmware Progress #0x05 | Motherboard initialization | Asserted
> 2 | 03/28/2016 | 11:22:38 | System Firmware Progress #0x05 | Memory initialization | Asserted
> 3 | 03/28/2016 | 11:22:55 | System Firmware Progress #0x05 | Secondary CPU Initialization | Asserted
> 4 | 03/28/2016 | 11:22:56 | System Firmware Progress #0x05 | System boot initiated | Asserted
> 5 | 03/28/2016 | 11:47:02 | System Firmware Progress #0x05 | Motherboard initialization | Asserteed
> ....
> ...
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>   sos/plugins/ipmitool.py |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sos/plugins/ipmitool.py b/sos/plugins/ipmitool.py
> index 41eaebc..6c9c531 100644
> --- a/sos/plugins/ipmitool.py
> +++ b/sos/plugins/ipmitool.py
> @@ -28,11 +28,11 @@ class IpmiTool(Plugin, RedHatPlugin, DebianPlugin):
>       def setup(self):
>           self.add_cmd_output([
>               "ipmitool sel info",
> -            "ipmitool sel log",
> +            "ipmitool sel list",
>               "ipmitool sensor list",
>               "ipmitool chassis status",
>               "ipmitool fru print",
> -            "ipmitool bmc info",
> +            "ipmitool mc info",
>               "ipmitool sdr info"
>           ])
>
>
> _______________________________________________
> sos-devel mailing list
> sos-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/sos-devel
>