From hegdevasant at linux.vnet.ibm.com Tue May 3 15:53:51 2016 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 3 May 2016 21:23:51 +0530 Subject: [sos-devel] [PATCH] [ipmi] Fix ipmitool options In-Reply-To: <20160414104922.6675.49798.stgit@hegdevasant.in.ibm.com> References: <20160414104922.6675.49798.stgit@hegdevasant.in.ibm.com> Message-ID: <5728C98F.1040808@linux.vnet.ibm.com> On 04/14/2016 04:19 PM, Vasant Hegde wrote: > As per ipmitool man page 'bmc' option is deprecreated. Instead use 'mc' > option to get BMC information. Hello Bryn, Any thoughts on this patch? -Vasant > > Also we don't have 'sel log' option. Use 'sel list' option to get SEL log > information. > > sample output: > > #ipmitool mc info: > Device ID : 32 > Device Revision : 1 > Firmware Revision : 2.13 > IPMI Version : 2.0 > Manufacturer ID : 0 > Manufacturer Name : Unknown > Product ID : 43707 (0xaabb) > Product Name : Unknown (0xAABB) > Device Available : yes > Provides Device SDRs : no > ... > ... > > #ipmitool sel list > 1 | 03/28/2016 | 11:22:10 | System Firmware Progress #0x05 | Motherboard initialization | Asserted > 2 | 03/28/2016 | 11:22:38 | System Firmware Progress #0x05 | Memory initialization | Asserted > 3 | 03/28/2016 | 11:22:55 | System Firmware Progress #0x05 | Secondary CPU Initialization | Asserted > 4 | 03/28/2016 | 11:22:56 | System Firmware Progress #0x05 | System boot initiated | Asserted > 5 | 03/28/2016 | 11:47:02 | System Firmware Progress #0x05 | Motherboard initialization | Asserteed > .... > ... > > Signed-off-by: Vasant Hegde > --- > sos/plugins/ipmitool.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sos/plugins/ipmitool.py b/sos/plugins/ipmitool.py > index 41eaebc..6c9c531 100644 > --- a/sos/plugins/ipmitool.py > +++ b/sos/plugins/ipmitool.py > @@ -28,11 +28,11 @@ class IpmiTool(Plugin, RedHatPlugin, DebianPlugin): > def setup(self): > self.add_cmd_output([ > "ipmitool sel info", > - "ipmitool sel log", > + "ipmitool sel list", > "ipmitool sensor list", > "ipmitool chassis status", > "ipmitool fru print", > - "ipmitool bmc info", > + "ipmitool mc info", > "ipmitool sdr info" > ]) > > > _______________________________________________ > sos-devel mailing list > sos-devel at redhat.com > https://www.redhat.com/mailman/listinfo/sos-devel > From builds at travis-ci.org Thu May 5 10:51:04 2016 From: builds at travis-ci.org (Travis CI) Date: Thu, 05 May 2016 10:51:04 +0000 Subject: [sos-devel] Passed: sosreport/sos#1405 (bmr-suse-sysroot-fix - 13a1b80) In-Reply-To: Message-ID: <572b259857d62_33fb8cae2aaa041354@f504da25-3ea8-4e32-865f-bee7bab58c37.mail> Build Update for sosreport/sos ------------------------------------- Build: #1405 Status: Passed Duration: 1 minute and 1 second Commit: 13a1b80 (bmr-suse-sysroot-fix) Author: Bryn M. Reeves Message: [suse] fix constructor sysroot argument The Policy class hierarchy requires a 'sysroot' kwarg for class constructors. This is used to pass the location of the actual host root file system for container configurations. The SuSE policy is currently missing this argument, leading to an exception during policy loading: Traceback (most recent call last): File "/usr/sbin/sosreport", line 25, in main(sys.argv[1:]) File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 1592, in main sos = SoSReport(args) File "/usr/lib/python2.7/site-packages/sos/sosreport.py", line 676, in init self.policy = sos.policies.load(sysroot=self.opts.sysroot) File "/usr/lib/python2.7/site-packages/sos/policies/init.py", line 38, in load cache['policy'] = policy(sysroot=sysroot) TypeError: init() got an unexpected keyword argument 'sysroot' Fixes #809. Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/commit/13a1b80ce970 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/128023696 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications -------------- next part -------------- An HTML attachment was scrubbed... URL: From lenohou at gmail.com Mon May 9 08:38:02 2016 From: lenohou at gmail.com (Leno Hou) Date: Mon, 9 May 2016 16:38:02 +0800 Subject: [sos-devel] [PATCH v1] [policies] Fix ibmkvm policy initialize function Message-ID: <1462783082-23667-1-git-send-email-lenohou@gmail.com> When loading policy, its leads failed load with sysroot. This patch updates the initialize function with sysroot Signed-off-by: Leno Hou --- sos/policies/ibmkvm.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sos/policies/ibmkvm.py b/sos/policies/ibmkvm.py index ff05953..c93f960 100644 --- a/sos/policies/ibmkvm.py +++ b/sos/policies/ibmkvm.py @@ -29,8 +29,8 @@ class PowerKVMPolicy(RedHatPolicy): vendor = "IBM" vendor_url = "http://www-03.ibm.com/systems/power/software/linux/powerkvm" - def __init__(self): - super(PowerKVMPolicy, self).__init__() + def __init__(self, sysroot=None): + super(PowerKVMPolicy, self).__init__(sysroot=sysroot) self.valid_subclasses = [PowerKVMPlugin, RedHatPlugin] @classmethod @@ -54,8 +54,8 @@ class ZKVMPolicy(RedHatPolicy): vendor = "IBM Hypervisor" vendor_url = "http://www.ibm.com/systems/z/linux/IBMHypervisor/support/" - def __init__(self): - super(ZKVMPolicy, self).__init__() + def __init__(self, sysroot=None): + super(ZKVMPolicy, self).__init__(sysroot=sysroot) self.valid_subclasses = [ZKVMPlugin, RedHatPlugin] @classmethod -- 1.9.1 From bmr at redhat.com Mon May 9 13:59:02 2016 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 9 May 2016 14:59:02 +0100 Subject: [sos-devel] [PATCH v1] [policies] Fix ibmkvm policy initialize function In-Reply-To: <1462783082-23667-1-git-send-email-lenohou@gmail.com> References: <1462783082-23667-1-git-send-email-lenohou@gmail.com> Message-ID: <20160509135901.GB29066@hex.redhat.com> On Mon, May 09, 2016 at 04:38:02PM +0800, Leno Hou wrote: > When loading policy, its leads failed load with sysroot. > This patch updates the initialize function with sysroot Ahh! I didn't know which policy you were using from the discussion on GitHub - I looked at SuSE (as it was the most recent policy that we merged) and found that had the bug too. I should've checked the other recent policies for this at the same time.. Thanks for the patch - I'll get this merged this week along with the SuSE one. Regards, Bryn. From lenohou at gmail.com Tue May 10 04:13:01 2016 From: lenohou at gmail.com (Leno Hou) Date: Tue, 10 May 2016 12:13:01 +0800 Subject: [sos-devel] [PATCH v1] [policies] Fix ibmkvm policy initialize function In-Reply-To: <20160509135901.GB29066@hex.redhat.com> References: <1462783082-23667-1-git-send-email-lenohou@gmail.com> <20160509135901.GB29066@hex.redhat.com> Message-ID: On Mon, May 9, 2016 at 9:59 PM, Bryn M. Reeves wrote: > On Mon, May 09, 2016 at 04:38:02PM +0800, Leno Hou wrote: > > When loading policy, its leads failed load with sysroot. > > This patch updates the initialize function with sysroot > > Ahh! I didn't know which policy you were using from the discussion on > GitHub - I looked at SuSE (as it was the most recent policy that we > merged) and found that had the bug too. > > I should've checked the other recent policies for this at the same > time.. > > Thanks for the patch - I'll get this merged this week along with the > SuSE one. > > Regards, > Bryn. > > Thanks Bryn. -------------- next part -------------- An HTML attachment was scrubbed... URL: From kamalesh at linux.vnet.ibm.com Thu May 12 07:48:13 2016 From: kamalesh at linux.vnet.ibm.com (Kamalesh Babulal) Date: Thu, 12 May 2016 13:18:13 +0530 Subject: [sos-devel] [PATCH] [policies] Adopt --sysroot from RedHat policy class Message-ID: <1463039293-7405-1-git-send-email-kamalesh@linux.vnet.ibm.com> commit 6a239ddeb5de (pass --sysroot down to policy classes), passes sysroot as part of init to RedHat policy. PowerKVMPolicy and ZKVMPolicy are subclasses derived from RedHat policy, so pass sysroot to them too. if sysroot is not passed to the subclasses, following exception is triggered: Traceback (most recent call last): File "./sosreport", line 25, in main(sys.argv[1:]) File "/root/rpmbuild/BUILD/sos/sos/sosreport.py", line 1635, in main sos = SoSReport(args) File "/root/rpmbuild/BUILD/sos/sos/sosreport.py", line 697, in __init__ self.policy = sos.policies.load(sysroot=self.opts.sysroot) File "/root/rpmbuild/BUILD/sos/sos/policies/__init__.py", line 38, in load cache['policy'] = policy(sysroot=sysroot) TypeError: __init__() got an unexpected keyword argument 'sysroot' Signed-off-by: Kamalesh Babulal --- sos/policies/ibmkvm.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sos/policies/ibmkvm.py b/sos/policies/ibmkvm.py index ff059532d528..c93f96061378 100644 --- a/sos/policies/ibmkvm.py +++ b/sos/policies/ibmkvm.py @@ -29,8 +29,8 @@ class PowerKVMPolicy(RedHatPolicy): vendor = "IBM" vendor_url = "http://www-03.ibm.com/systems/power/software/linux/powerkvm" - def __init__(self): - super(PowerKVMPolicy, self).__init__() + def __init__(self, sysroot=None): + super(PowerKVMPolicy, self).__init__(sysroot=sysroot) self.valid_subclasses = [PowerKVMPlugin, RedHatPlugin] @classmethod @@ -54,8 +54,8 @@ class ZKVMPolicy(RedHatPolicy): vendor = "IBM Hypervisor" vendor_url = "http://www.ibm.com/systems/z/linux/IBMHypervisor/support/" - def __init__(self): - super(ZKVMPolicy, self).__init__() + def __init__(self, sysroot=None): + super(ZKVMPolicy, self).__init__(sysroot=sysroot) self.valid_subclasses = [ZKVMPlugin, RedHatPlugin] @classmethod -- 2.6.0.rc1 From bmr at redhat.com Fri May 13 11:18:15 2016 From: bmr at redhat.com (Bryn M. Reeves) Date: Fri, 13 May 2016 12:18:15 +0100 Subject: [sos-devel] [PATCH] [policies] Adopt --sysroot from RedHat policy class In-Reply-To: <1463039293-7405-1-git-send-email-kamalesh@linux.vnet.ibm.com> References: <1463039293-7405-1-git-send-email-kamalesh@linux.vnet.ibm.com> Message-ID: <20160513111815.GC14132@hex> On Thu, May 12, 2016 at 01:18:13PM +0530, Kamalesh Babulal wrote: > commit 6a239ddeb5de (pass --sysroot down to policy classes), > passes sysroot as part of init to RedHat policy. PowerKVMPolicy > and ZKVMPolicy are subclasses derived from RedHat policy, > so pass sysroot to them too. https://github.com/sosreport/sos/issues/809 Bug is also present in the SuSE policy. I'll fix all three together either today or early next week. Regards, Bryn. From kamalesh at linux.vnet.ibm.com Mon May 16 04:39:43 2016 From: kamalesh at linux.vnet.ibm.com (Kamalesh Babulal) Date: Mon, 16 May 2016 10:09:43 +0530 Subject: [sos-devel] [PATCH] [policies] Adopt --sysroot from RedHat policy class In-Reply-To: <20160513111815.GC14132@hex> References: <1463039293-7405-1-git-send-email-kamalesh@linux.vnet.ibm.com> <20160513111815.GC14132@hex> Message-ID: <57394F0F.3030406@linux.vnet.ibm.com> On Friday 13 May 2016 04:48 PM, Bryn M. Reeves wrote: > On Thu, May 12, 2016 at 01:18:13PM +0530, Kamalesh Babulal wrote: >> commit 6a239ddeb5de (pass --sysroot down to policy classes), >> passes sysroot as part of init to RedHat policy. PowerKVMPolicy >> and ZKVMPolicy are subclasses derived from RedHat policy, >> so pass sysroot to them too. > https://github.com/sosreport/sos/issues/809 > > Bug is also present in the SuSE policy. I'll fix all three together either > today or early next week. > > Thank you Bryn :) -- Cheers, Kamalesh