From hegdevasant at linux.vnet.ibm.com Tue Jan 3 06:11:41 2017 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 3 Jan 2017 11:41:41 +0530 Subject: [sos-devel] [PATCH RESEND 1/2] plugin/powerpc : Removes lsvpd family commands from powerpc.py plugin In-Reply-To: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> References: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> Message-ID: <586B409D.40006@linux.vnet.ibm.com> On 12/21/2016 03:57 PM, Mukesh Ojha wrote: > lsvpd family commands captures information, which can be extracted from > /var/lib/lsvpd. So, avoid capturing duplicate information by skipping > the execution of these command. Bryn, /var/lib/lsvpd directory contains sqlite based database which contains system VPD. all the tools removed in this patch just reads/prints data from this database. Hence to avoid duplication and save sosreport execution time, we are removing these command output from sosreport. I've reviewed this patch and looks good to me. Reviewed-by: Vasant Hegde -Vasant > > Signed-off-by: Mukesh Ojha > Reviewed-by: Kamalesh Babulal > --- > sos/plugins/powerpc.py | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py > index 9252cf2..517175c 100644 > --- a/sos/plugins/powerpc.py > +++ b/sos/plugins/powerpc.py > @@ -56,10 +56,7 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): > "ppc64_cpu --cores-on", > "ppc64_cpu --run-mode", > "ppc64_cpu --frequency", > - "ppc64_cpu --dscr", > - "lscfg -vp", > - "lsmcode -A", > - "lsvpd --debug" > + "ppc64_cpu --dscr" > ]) > > if ispSeries: > @@ -70,7 +67,6 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): > "/var/log/platform" > ]) > self.add_cmd_output([ > - "lsvio -des", > "servicelog --dump", > "servicelog_notify --list", > "usysattn", > From hegdevasant at linux.vnet.ibm.com Tue Jan 3 06:13:49 2017 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Tue, 3 Jan 2017 11:43:49 +0530 Subject: [sos-devel] [PATCH RESEND 2/2] plugin/powerpc : Added diag_encl command output to sosreport In-Reply-To: <1482316027-20653-2-git-send-email-mukesh02@linux.vnet.ibm.com> References: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> <1482316027-20653-2-git-send-email-mukesh02@linux.vnet.ibm.com> Message-ID: <586B411D.2050502@linux.vnet.ibm.com> On 12/21/2016 03:57 PM, Mukesh Ojha wrote: > This patch enables sosreport to collect "diag_encl -v" command output. Bryn, diag_encl is a Power System specific tool to diagnoze SES enclosures. It contains various useful information to diagnoze SES enclosures. Hence we are adding this under powerpc.py plugin. Reviewed-by: Vasant Hegde -Vasant > > Signed-off-by: Mukesh Ojha > Signed-off-by: Ankit Kumar > Tested-by: Mukesh Ojha > --- > sos/plugins/powerpc.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py > index 517175c..a4c92d0 100644 > --- a/sos/plugins/powerpc.py > +++ b/sos/plugins/powerpc.py > @@ -56,7 +56,8 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): > "ppc64_cpu --cores-on", > "ppc64_cpu --run-mode", > "ppc64_cpu --frequency", > - "ppc64_cpu --dscr" > + "ppc64_cpu --dscr", > + "diag_encl -v" > ]) > > if ispSeries: > From mukesh02 at linux.vnet.ibm.com Mon Jan 23 05:12:28 2017 From: mukesh02 at linux.vnet.ibm.com (Mukesh Ojha) Date: Mon, 23 Jan 2017 10:42:28 +0530 Subject: [sos-devel] [PATCH RESEND 1/2] plugin/powerpc : Removes lsvpd family commands from powerpc.py plugin In-Reply-To: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> References: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> Message-ID: Hi Bryn, Can you please have a look at this patchset? Regards, Mukesh On Wednesday 21 December 2016 03:57 PM, Mukesh Ojha wrote: > lsvpd family commands captures information, which can be extracted from > /var/lib/lsvpd. So, avoid capturing duplicate information by skipping > the execution of these command. > > Signed-off-by: Mukesh Ojha > Reviewed-by: Kamalesh Babulal > --- > sos/plugins/powerpc.py | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py > index 9252cf2..517175c 100644 > --- a/sos/plugins/powerpc.py > +++ b/sos/plugins/powerpc.py > @@ -56,10 +56,7 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): > "ppc64_cpu --cores-on", > "ppc64_cpu --run-mode", > "ppc64_cpu --frequency", > - "ppc64_cpu --dscr", > - "lscfg -vp", > - "lsmcode -A", > - "lsvpd --debug" > + "ppc64_cpu --dscr" > ]) > > if ispSeries: > @@ -70,7 +67,6 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin): > "/var/log/platform" > ]) > self.add_cmd_output([ > - "lsvio -des", > "servicelog --dump", > "servicelog_notify --list", > "usysattn", From bmr at redhat.com Mon Jan 23 08:42:55 2017 From: bmr at redhat.com (Bryn M. Reeves) Date: Mon, 23 Jan 2017 08:42:55 +0000 Subject: [sos-devel] [PATCH RESEND 1/2] plugin/powerpc : Removes lsvpd family commands from powerpc.py plugin In-Reply-To: References: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> Message-ID: <20170123084255.GA4486@localhost.localdomain> On Mon, Jan 23, 2017 at 10:42:28AM +0530, Mukesh Ojha wrote: > Hi Bryn, > > Can you please have a look at this patchset? > > Regards, > Mukesh Hi Mukesh, It will be reviewed before 3.4 is released (target is March 2017). Please see the milestone information on the GitHub project pages for more details. Regards, Bryn. From mukesh02 at linux.vnet.ibm.com Mon Jan 23 08:45:23 2017 From: mukesh02 at linux.vnet.ibm.com (Mukesh Ojha) Date: Mon, 23 Jan 2017 14:15:23 +0530 Subject: [sos-devel] [PATCH RESEND 1/2] plugin/powerpc : Removes lsvpd family commands from powerpc.py plugin In-Reply-To: <20170123084255.GA4486@localhost.localdomain> References: <1482316027-20653-1-git-send-email-mukesh02@linux.vnet.ibm.com> <20170123084255.GA4486@localhost.localdomain> Message-ID: <0954efb5-1e80-a0ce-6159-a7ae14a3ec77@linux.vnet.ibm.com> On Monday 23 January 2017 02:12 PM, Bryn M. Reeves wrote: > On Mon, Jan 23, 2017 at 10:42:28AM +0530, Mukesh Ojha wrote: >> Hi Bryn, >> >> Can you please have a look at this patchset? >> >> Regards, >> Mukesh > Hi Mukesh, > > It will be reviewed before 3.4 is released (target is March 2017). > > Please see the milestone information on the GitHub project pages > for more details. > > Regards, > Bryn. > Thanks for the info, Bryn . :-) Regards, Mukesh