[sos-devel] [PATCH RESEND 1/2] plugin/powerpc : Removes lsvpd family commands from powerpc.py plugin

[Vasant Hegde]

On 12/21/2016 03:57 PM, Mukesh Ojha wrote:
> lsvpd family commands captures information, which can be extracted from
> /var/lib/lsvpd. So, avoid capturing duplicate information by skipping
> the execution of these command.

Bryn,

/var/lib/lsvpd directory contains sqlite based database which contains system 
VPD. all the tools removed in this patch just reads/prints data from this 
database.  Hence to avoid duplication and save sosreport execution time, we are 
removing these command output from sosreport.

I've reviewed this patch and looks good to me.

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

-Vasant

>
> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
> Reviewed-by: Kamalesh Babulal <kamalesh at linux.vnet.ibm.com>
> ---
>   sos/plugins/powerpc.py | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sos/plugins/powerpc.py b/sos/plugins/powerpc.py
> index 9252cf2..517175c 100644
> --- a/sos/plugins/powerpc.py
> +++ b/sos/plugins/powerpc.py
> @@ -56,10 +56,7 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin):
>                   "ppc64_cpu --cores-on",
>                   "ppc64_cpu --run-mode",
>                   "ppc64_cpu --frequency",
> -                "ppc64_cpu --dscr",
> -                "lscfg -vp",
> -                "lsmcode -A",
> -                "lsvpd --debug"
> +                "ppc64_cpu --dscr"
>               ])
>
>           if ispSeries:
> @@ -70,7 +67,6 @@ class PowerPC(Plugin, RedHatPlugin, UbuntuPlugin, DebianPlugin):
>                   "/var/log/platform"
>               ])
>               self.add_cmd_output([
> -                "lsvio -des",
>                   "servicelog --dump",
>                   "servicelog_notify --list",
>                   "usysattn",
>