[sos-devel] Passed: sosreport/sos#3111 (bmr-get-option-fix-1498 - 2206e71)

Travis CI builds at travis-ci.org
Wed Dec 12 10:27:28 UTC 2018


Build Update for sosreport/sos
-------------------------------------

Build: #3111
Status: Passed

Duration: 2 mins and 7 secs
Commit: 2206e71 (bmr-get-option-fix-1498)
Author: Bryn M. Reeves
Message: [Plugin] fix get_option() on Python3 runtimes

The get_option() method uses an internal helper function, _check(),
that tests for matching options that are either strings (equality
test), or iterable types (value present test).

The function assumes that if an __iter__ attribute is present that
it is dealing with an iterable - a list or tuple for e.g.. In the
Python3 string classes this attribute is present (since a string
can be iterated to obtain the characters it contains).

Fix the test by instead testing for the presence of the 'encode'
method which is present on all string types in supported Python 2
and 3 runtimes.

Resolves: #1498.

Signed-off-by: Bryn M. Reeves <bmr at redhat.com>

View the changeset: https://github.com/sosreport/sos/commit/2206e7136a3a

View the full build log and details: https://travis-ci.org/sosreport/sos/builds/466929353?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the sosreport/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=819743&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/sos-devel/attachments/20181212/7185d4c8/attachment.htm>


More information about the sos-devel mailing list