[sos-devel] [PATCH] [openvswitch] Add DPDK port mempool information.
Bryn M. Reeves
bmr at redhat.com
Wed Feb 7 16:36:15 UTC 2018
On Wed, Feb 07, 2018 at 04:28:49PM +0000, Kevin Traynor wrote:
> + # Gather info on the DPDK mempools associated with each DPDK port
> + br_list_result = self.call_ext_prog("ovs-vsctl -t 5 list-br")
> + if br_list_result['status'] == 0:
> + for br in br_list_result['output'].splitlines():
> + port_list_result = self.call_ext_prog("ovs-vsctl -t 5 list-ports %s" % br)
> + if port_list_result['status'] == 0:
> + for port in port_list_result['output'].splitlines():
> + self.add_cmd_output([
> + "ovs-appctl netdev-dpdk/get-mempool-info %s" % port
> + ])
No need for [] here - add_cmd_output() and add_copy_spec() both accept
either a single string, or a list of strings.
Aside from that the patch looks good, thanks. No need to resend for a
minor style fix: I'll change those two lines when I merge.
Regards,
Bryn.
More information about the sos-devel
mailing list