[sos-devel] PR 1398 [pmem plugin] is not yet integrated into SOS v3.7

Bryn M. Reeves bmr at redhat.com
Thu Aug 29 09:56:21 UTC 2019


On Fri, Aug 23, 2019 at 03:37:58PM +0000, Scargall, Steve wrote:
> I'm following up on my [old] pull request (https://github.com/sosreport/sos/pull/1398) for a new Persistent Memory plugin.  It was closed and marked for integration in to SOS v3.7, thank you, but it doesn't seem to have ever made it in to the current release.  Was it accidentally missed or do I need to do something?

Hi Steve,

Sos-devel is a subscriber-only list, so your message was stuck in the moderation queue - I've added you to the accepts filter now, so future posts will appear, but you can subscribe or change options by visiting the listinfo page here:

  https://www.redhat.com/mailman/listinfo/sos-devel

The commit was merged for PR1398, but it looks like there was a problem with your later rebases and updates to the branch - the final commit ended up just removing a line of comment:

  https://github.com/sosreport/sos/pull/1398/commits/6b3af9ec7af95b5a38b1e55e6da89ae3ab20b0d4

The commit changes to actually add the plugin seem to have vanished from the branch.

We can restore the plugin from older commits and get it queued for the next release:

  https://github.com/sosreport/sos/commit/18ccac7ba79c1202c5cdfb26fbf8c5a6beee4a58
  https://github.com/sosreport/sos/commit/ad896c71fa8c6caf652eeab37295bea72300f111

Regards,
Bryn.




More information about the sos-devel mailing list