From bmr at redhat.com Wed Feb 6 16:46:24 2019 From: bmr at redhat.com (Bryn M. Reeves) Date: Wed, 6 Feb 2019 16:46:24 +0000 Subject: [sos-devel] [announce] LGTM reviews for sos PRs Message-ID: <20190206164623.GA6160@localhost.localdomain> Hi Folks, I've experimentally turned on automatic LGTM reviews for sos pull requests. LGTM is a static code analysis suite for Python that produces a report on possible errors and language misuse. You can view the current report for sos master here: https://lgtm.com/projects/g/sosreport/sos/ There are roughly 50 currently, and on a quick scan most are an actionable bug (although some with very low/no impact). We'll be working through these over the next few weeks, although feel free to submit PRs for any outstanding items you notice. If the reviews seem useful we'll start to incorporate them in the routine sos review process. LMK if it LGTY! Regards, Bryn. From pmoravec at redhat.com Thu Feb 7 11:22:40 2019 From: pmoravec at redhat.com (Pavel Moravec) Date: Thu, 7 Feb 2019 12:22:40 +0100 Subject: [sos-devel] [announce] LGTM reviews for sos PRs In-Reply-To: <20190206164623.GA6160@localhost.localdomain> References: <20190206164623.GA6160@localhost.localdomain> Message-ID: On Wed, Feb 6, 2019 at 5:46 PM Bryn M. Reeves wrote: > Hi Folks, > > I've experimentally turned on automatic LGTM reviews for sos pull > requests. > > LGTM is a static code analysis suite for Python that produces a > report on possible errors and language misuse. You can view the > current report for sos master here: > > https://lgtm.com/projects/g/sosreport/sos/ > > There are roughly 50 currently, and on a quick scan most are an > actionable bug (although some with very low/no impact). We'll > be working through these over the next few weeks, although feel > free to submit PRs for any outstanding items you notice. > > If the reviews seem useful we'll start to incorporate them in > the routine sos review process. > > LMK if it LGTY! > > Regards, > Bryn. > Nice and useful initiative, thanks for that! I started to review the warnings, but I feel some of them are red herrings: 1) Both errors https://lgtm.com/projects/g/sosreport/sos/alerts/?mode=list&severity=error does not treat a r.e. in string like """ ^ .. $ """ properly, as I think they treat the leading whitespace before ^ and before closing """ as valid chars (they arent) 2) for-else construction at https://lgtm.com/projects/g/sosreport/sos/snapshot/904808a29893d182621cf32cb9074b50f817b9a1/files/sos/plugins/__init__.py?sort=name&dir=ASC&mode=heatmap#L517 is also valid - "return" _is_ kind of break :) 3) dead code at https://github.com/sosreport/sos/blob/master/sos/sosreport.py#L126 revealed the fact no xml reports are generated at all :) (self.enabled = False all the time) - since this is the case for years, doesn't it make sense to remove the XmlReport completely? (that would get rid of 2 other warnings) For the 3) and many valid warnings, I raised #1559 now. Kind regards, Pavel -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Thu Feb 7 11:49:48 2019 From: builds at travis-ci.org (Travis CI) Date: Thu, 07 Feb 2019 11:49:48 +0000 Subject: [sos-devel] Broken: sosreport/sos#3200 (master - ed8c59e) In-Reply-To: Message-ID: <5c5c1b5b9918d_43f895bea3fc02940fc@bf884237-af43-4379-82aa-d4d30a67fc37.mail> Build Update for sosreport/sos ------------------------------------- Build: #3200 Status: Broken Duration: 2 mins and 37 secs Commit: ed8c59e (master) Author: Pavel Moravec Message: [satellite] don't collect /root/ssl-build Recursive listing of the directory is sufficient. Resolves: #1555 Signed-off-by: Pavel Moravec View the changeset: https://github.com/sosreport/sos/compare/d579fb745de0...ed8c59e9fd6a View the full build log and details: https://travis-ci.org/sosreport/sos/builds/490008798?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the sosreport/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=819743&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Thu Feb 7 13:04:10 2019 From: builds at travis-ci.org (Travis CI) Date: Thu, 07 Feb 2019 13:04:10 +0000 Subject: [sos-devel] Passed: psachin/sos#65 (fix_lgtm_warning_for_ibmkvm_policy - c565c2f) In-Reply-To: Message-ID: <5c5c2cc969b8b_43fcd0561baa4394172@064a4c33-3ddf-4ace-9b4d-562560372f33.mail> Build Update for psachin/sos ------------------------------------- Build: #65 Status: Passed Duration: 3 mins and 10 secs Commit: c565c2f (fix_lgtm_warning_for_ibmkvm_policy) Author: Sachin Patil Message: [policies.ibmkvm] Fix unhandled return statements reported by LGTM Two of the return statements were not reachable and the exceptions were directly handling `return`[1] https://lgtm.com/projects/g/sosreport/sos/rev/8cded9af8d1d75f4896699f83ae3ce289337dd6b Signed-off-by: Sachin Patil View the changeset: https://github.com/psachin/sos/compare/cf676ebdbe91^...c565c2f5dec6 View the full build log and details: https://travis-ci.org/psachin/sos/builds/490038531?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the psachin/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=7627784&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Tue Feb 12 00:50:57 2019 From: builds at travis-ci.org (Travis CI) Date: Tue, 12 Feb 2019 00:50:57 +0000 Subject: [sos-devel] Still Failing: BryanQuigley/sos#114 (logs - 1707eb7) In-Reply-To: Message-ID: <5c6218719009_43fd0a1cb30e89299b@50c61e65-070a-4dad-b97c-536be1918b20.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #114 Status: Still Failing Duration: 2 mins and 8 secs Commit: 1707eb7 (logs) Author: Bryan Quigley Message: [logs] Debian: Add Journal support and stop full tarball of /var/log These changes are only on the Debian/Ubuntu bit of logs Persistent systemd journaling (/var/log/journal exists) use that instead of collecting any kern/syslog/auth from /var/log. We also implement a log_days similar to the RH bit, but we default to 7 days instead of 3. --all-logs removes the day limit and gets it all Rsyslog style (assumed if /var/log/journal doesn't exist default run: collect all 4 of syslog[.1] and kern.log[.1] (Same as previous behavior plus auth.log). --all-logs: collect syslog*, kern.log*, and auth.log* The notable change for --all-logs is it used to just collect all of /var/log which causes MANY issues. Before this change using --all-logs on systems with persistent journal we would collect duplicate log files as such: * Collect all of syslog*/kern*/auth* * Collect the entire journal via /var/log/journal * Collect the last two boots of journal via running journalctl command Even with this change we still collect the journal last/current boot with whatever is copied by journal since log_days. Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/compare/fdf89aee8c22...1707eb7c70e1 View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/491920536?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Tue Feb 12 01:04:18 2019 From: builds at travis-ci.org (Travis CI) Date: Tue, 12 Feb 2019 01:04:18 +0000 Subject: [sos-devel] Fixed: BryanQuigley/sos#115 (master - 33054e8) In-Reply-To: Message-ID: <5c621b91ecb40_43faf92017c9c103224@ef31864b-c3c9-4d84-bedb-049913b37c17.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #115 Status: Fixed Duration: 2 mins and 53 secs Commit: 33054e8 (master) Author: Pavel Moravec Message: [general] fix pycodestyle indentation errors Resolves: #1556 Signed-off-by: Pavel Moravec View the changeset: https://github.com/BryanQuigley/sos/compare/d579fb745de0...33054e81f50d View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/491924895?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Tue Feb 12 01:06:28 2019 From: builds at travis-ci.org (Travis CI) Date: Tue, 12 Feb 2019 01:06:28 +0000 Subject: [sos-devel] Fixed: BryanQuigley/sos#116 (logs - 09ca05b) In-Reply-To: Message-ID: <5c621c13dd8bd_43f9d4dd16abc949f4@9aa2016c-d928-4a45-8c36-92ef0ae94013.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #116 Status: Fixed Duration: 5 mins and 6 secs Commit: 09ca05b (logs) Author: Bryan Quigley Message: [logs] Debian: Add Journal support and stop full tarball of /var/log These changes are only on the Debian/Ubuntu bit of logs Persistent systemd journaling (/var/log/journal exists) use that instead of collecting any kern/syslog/auth from /var/log. We also implement a log_days similar to the RH bit, but we default to 7 days instead of 3. --all-logs removes the day limit and gets it all Rsyslog style (assumed if /var/log/journal doesn't exist default run: collect all 4 of syslog[.1] and kern.log[.1] (Same as previous behavior plus auth.log). --all-logs: collect syslog*, kern.log*, and auth.log* The notable change for --all-logs is it used to just collect all of /var/log which causes MANY issues. Before this change using --all-logs on systems with persistent journal we would collect duplicate log files as such: * Collect all of syslog*/kern*/auth* * Collect the entire journal via /var/log/journal * Collect the last two boots of journal via running journalctl command Even with this change we still collect the journal last/current boot with whatever is copied by journal since log_days. Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/compare/1707eb7c70e1...09ca05b33add View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/491924908?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Thu Feb 14 21:29:24 2019 From: builds at travis-ci.org (Travis CI) Date: Thu, 14 Feb 2019 21:29:24 +0000 Subject: [sos-devel] Passed: BryanQuigley/sos#117 (environment - 71146dd) In-Reply-To: Message-ID: <5c65ddb433cf1_43fb09a4a072466174@fc29609c-518a-4ebd-8e9d-3e80e713c950.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #117 Status: Passed Duration: 4 mins and 1 sec Commit: 71146dd (environment) Author: Bryan Quigley Message: [pam] collect /etc/environment Resolves: #1550 Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/commit/71146dddac7c View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/493455804?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Thu Feb 14 22:55:48 2019 From: builds at travis-ci.org (Travis CI) Date: Thu, 14 Feb 2019 22:55:48 +0000 Subject: [sos-devel] Errored: BryanQuigley/sos#118 (resolved - f6f5466) In-Reply-To: Message-ID: <5c65f1f3c0716_43f883bc7b7645123d@97dd6472-a8d6-44f5-b6cd-75fbc7222d2a.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #118 Status: Errored Duration: 2 mins and 14 secs Commit: f6f5466 (resolved) Author: Bryan Quigley Message: [systemd] Add many other lists, statuses, *ctls systemctl list-jobs - any currently runnign list-dependencies - nice dependency tree list-timers --all - what timers are setup/active list-machines - for systemd container orcestration systemd-resolve --status - what link is using what dns server, etc --statistics - how cache/DNSSEC/etc are doing busctl list - shows what's on the dbus (but likely future proof if new bus) status - shows systemds status on the bus bootctl (primarily for the systemd built-in boot) list - boot loader entries if using the spec status - brief info about the system boot I'm leaving other *ctls alone like locatectl and networkctl. But we likely need to figure out how to handle them as well. Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/commit/f6f5466595f8 View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/493493741?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Thu Feb 14 22:58:08 2019 From: builds at travis-ci.org (Travis CI) Date: Thu, 14 Feb 2019 22:58:08 +0000 Subject: [sos-devel] Passed: BryanQuigley/sos#119 (resolved - b0e5341) In-Reply-To: Message-ID: <5c65f2806348a_43ff37d69bd7870bf@e611b591-69c6-44f5-9bb3-b34679baacbf.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #119 Status: Passed Duration: 3 mins and 24 secs Commit: b0e5341 (resolved) Author: Bryan Quigley Message: [systemd] Add many other lists, statuses, *ctls systemctl list-jobs - any currently runnign list-dependencies - nice dependency tree list-timers --all - what timers are setup/active list-machines - for systemd container orcestration systemd-resolve --status - what link is using what dns server, etc --statistics - how cache/DNSSEC/etc are doing busctl list - shows what's on the dbus (but likely future proof if new bus) status - shows systemds status on the bus bootctl (primarily for the systemd built-in boot) list - boot loader entries if using the spec status - brief info about the system boot I'm leaving other *ctls alone like locatectl and networkctl. But we likely need to figure out how to handle them as well. Resolves: #1457 Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/compare/f6f5466595f8...b0e534195ce5 View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/493494216?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Fri Feb 15 19:47:34 2019 From: builds at travis-ci.org (Travis CI) Date: Fri, 15 Feb 2019 19:47:34 +0000 Subject: [sos-devel] Passed: BryanQuigley/sos#123 (rclocal - 1e0537c) In-Reply-To: Message-ID: <5c671755d8249_43fb09a4aa6c0411776@fc29609c-518a-4ebd-8e9d-3e80e713c950.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #123 Status: Passed Duration: 2 mins and 48 secs Commit: 1e0537c (rclocal) Author: Bryan Quigley Message: [services] add rc.local Resolves: #1545 Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/commit/1e0537c39cff View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/493925089?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Fri Feb 15 19:52:14 2019 From: builds at travis-ci.org (Travis CI) Date: Fri, 15 Feb 2019 19:52:14 +0000 Subject: [sos-devel] Passed: BryanQuigley/sos#124 (rclocal2 - 9d45842) In-Reply-To: Message-ID: <5c67186e2e437_43fc192f6447c208021@4ba6aa1e-f323-4ff0-8b70-2ff11455edaa.mail> Build Update for BryanQuigley/sos ------------------------------------- Build: #124 Status: Passed Duration: 2 mins and 38 secs Commit: 9d45842 (rclocal2) Author: Bryan Quigley Message: [services] add rc.local Resolves: #1545 Signed-off-by: Bryan Quigley View the changeset: https://github.com/BryanQuigley/sos/commit/9d4584226e17 View the full build log and details: https://travis-ci.org/BryanQuigley/sos/builds/493927172?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the BryanQuigley/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=12244263&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Thu Feb 21 12:54:16 2019 From: builds at travis-ci.org (Travis CI) Date: Thu, 21 Feb 2019 12:54:16 +0000 Subject: [sos-devel] Passed: sosreport/sos#3221 (bmr-predicates - d2ac38c) In-Reply-To: Message-ID: <5c6e9f76565c6_43fbc1c70bb841881d2@a7390e66-5cf5-4da1-ac83-4b130a9fc547.mail> Build Update for sosreport/sos ------------------------------------- Build: #3221 Status: Passed Duration: 2 mins and 0 secs Commit: d2ac38c (bmr-predicates) Author: Bryn M. Reeves Message: [SCRATCH][kernel] demonstrate capture gating by kmod list Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/e0d8559b87d5^...d2ac38ca4da5 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/496485540?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the sosreport/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=819743&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: From builds at travis-ci.org Wed Feb 27 12:02:27 2019 From: builds at travis-ci.org (Travis CI) Date: Wed, 27 Feb 2019 12:02:27 +0000 Subject: [sos-devel] Passed: sosreport/sos#3236 (bmr-direct-write-cmd-output - 86b999e) In-Reply-To: Message-ID: <5c767c5355ad3_43fe2c7fc882c11242b@2cfc4ff0-9996-4755-b4cf-ac69dedba0c0.mail> Build Update for sosreport/sos ------------------------------------- Build: #3236 Status: Passed Duration: 2 mins and 36 secs Commit: 86b999e (bmr-direct-write-cmd-output) Author: Bryn M. Reeves Message: [Plugin] have add_journal() request direct command output Signed-off-by: Bryn M. Reeves View the changeset: https://github.com/sosreport/sos/compare/8f09d274be59^...86b999e16291 View the full build log and details: https://travis-ci.org/sosreport/sos/builds/499230488?utm_medium=notification&utm_source=email -- You can unsubscribe from build emails from the sosreport/sos repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=819743&utm_medium=notification&utm_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. -------------- next part -------------- An HTML attachment was scrubbed... URL: