[Spacewalk-list] Spacewalk 1.4 channel and even question/challenge

[Michael Gliwinski]

On Wednesday 18 May 2011 13:08:24 Michael Gliwinski wrote:
> > # spacewalk-repo-sync --channel=sl6-i386-epel6 --type=yumsubset
> > Error: Unknown type yumsubset
> > 
> > After some digging in the code I found the error was being generated by
> > /usr/lib/python2.6/site-packages/spacewalk/satellite_tools/reposync.py
> > 
> > After changing line 62 to
> > 
> >   if options.type not in ["yum","yumsubset"]:
> Uhm, hardcoded types?  I wonder why.  I added another type because I didn't
> want to have to patch the builtin type with each new release.  Could any
> devs comment on that change?

OK, found that this was introduced in 62f4d5ef491fc0b47e6ab7e4974b6ab7c7e962c2 
to prevent backtrace if invalid type was given.  Could this be better handled 
by e.g.:

  try:
      self.load_plugin()
  except ...

> No, the rest seems fine, just the changes to reposync broke it.  When I
> have some time I'll try to find the relevant code in on-line repo browser
> and see if I can do anything to fix it.

Yip, reposync and yum_src (from which yumsubset_src was copied) have changed.  
I'll need to go through and re-integrate my changes.


-- 
Michael Gliwinski
Henderson Group Information Services
9-11 Hightown Avenue, Newtownabby, BT36 4RT
Phone: 028 9034 3319

**********************************************************************************************
The information in this email is confidential and may be legally privileged.  It is intended solely for the addressee and access to the email by anyone else is unauthorised.
If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.
When addressed to our clients, any opinions or advice contained in this e-mail are subject to the terms and conditions expressed  in the governing client engagement leter or contract.
If you have received this email in error please notify support at henderson-group.com

John Henderson (Holdings) Ltd
Registered office: 9 Hightown Avenue, Mallusk, County Antrim, Northern Ireland, BT36 4RT.
Registered in Northern Ireland
Registration Number NI010588
Vat No.: 814 6399 12
*********************************************************************************