[Spacewalk-list] Bugs in Spacewalk/PostgreSQL

[Jan Pazdziora]

On Mon, Nov 21, 2011 at 11:09:41AM +0100, Jan Pazdziora wrote:
> On Fri, Nov 04, 2011 at 04:41:02PM +0000, Wojtak, Greg wrote:
> > I've attached a patch for /usr/share/perl5/RHN/DB/Action.pm.
> 
> Thank you.
> 
> A few comments:
> 
> The patch seems to use just CR (no LF) as line ends which prevents it
> to be applied. You might want to preserve the newline characters.
> 
> The patch was a reverse patch.
> 
> In general, you might want to use git format-patch to get it created
> for you.
> 
> You seem to have introduced quite a lot of whitespace changes which
> add unnecessary noise and can hide actual issues with the patch. For
> example, the first chunk does
> 
>  SELECT A.id
> -  FROM rhnAction A,
> -       rhnServerAction SA
> - WHERE SA.server_id = :server_id
> + FROM rhnAction A,
> +      rhnServerAction SA
> +  WHERE SA.server_id = :server_id
>     AND SA.status = 0
> -   AND SA.action_id = A.id
>     AND A.prerequisite IS NULL
>  ORDER BY A.id;
> 
> which removes the
> 
> 	AND SA.action_id = A.id
> 
> join -- that does not sound correct.
> 
> Would you like to give the patch another try to fix these issues?

Anyway, I've polished the patch and pushed the change to Spacewalk
master as 91b2ab3bcb08aa0d051f04b72d43f81f29009c71 now.

Thanks!

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat