[Spacewalk-list] Import of errata broken after upgrade from 2.5 to 2.6

[Ree, Jan-Albert van]

I immediately tested your patch on my test server and it works perfectly. Errata are parsed correctly again.
I'll update the spacewalk bugzilla report with a confirmation of succes with your patch.
Thanks for the awesome work :)
--
Jan-Albert


Jan-Albert van Ree  | Linux System Administrator | MARIN Support Group
MARIN | T +31 317 49 35 48 | mailto:J.A.v.Ree at marin.nl | http://www.marin.nl

MARIN news: http://www.marin.nl/web/News/News-items/Comparison-of-uRANS-and-BEMBEM-for-propeller-pressure-pulse-prediction.htm

________________________________________
From: spacewalk-list-bounces at redhat.com <spacewalk-list-bounces at redhat.com> on behalf of Patrick Hurrelmann <patrick.hurrelmann at lobster.de>
Sent: Thursday, December 29, 2016 14:29
To: spacewalk-list at redhat.com
Subject: Re: [Spacewalk-list] Import of errata broken after upgrade from 2.5 to 2.6

On 29.12.2016 10:02, Patrick Hurrelmann wrote:
> On 21.12.2016 10:24, Ree, Jan-Albert van wrote:
>> Since I haven't heard anybody else about this issue yet and haven't seen any activity on the bug I reported I thought I'd ask around here....
>> Has anybody else noticed that errata no longer get imported after upgrading from Spacewalk 2.5 to 2.6 ?
>>
>> Since the upgrade at the end of every yum reposync I see the following error in the rhn_taskomatic_daemon.log file :
>>
>> ERROR com.redhat.rhn.taskomatic.task.RepoSyncTask - 04:04:07 ERROR: cannot concatenate 'str' and 'int' objects
>>
>> I've seen this behaviour on two separate machines, both running Scientific Linux 7 and both immediately after a fully working Spacewalk 2.5 instance was upgraded to 2.6
>> Both machines use a local postgresql-9.2.15 database
>>
>> My bug report : https://bugzilla.redhat.com/show_bug.cgi?id=1401488
>>
>> Regards,
>> --
>> Jan-Albert
> Hi Jan-Albert,
>
> I just updated to 2.6 and I'm facing the very same error. This is on an
> fully updated CentOS 7.3.
> Looks like an ugly regression.
>
> Regards
> Patrick
>

Hi everyone,

I digged deeper and probably found the culprit. Commit
5923c05266b8ecdc165c1e14f2b2e62a9acc1295 [1]
seems to have introduced this regression. I created small patch and it
works for me, but the fix may be wrong
though. Anyway, I created the PR#497 [2] to address this. If you are
willing to try it yourself, please get the
patch from the PR [3] or use the attached patch (if it makes it through
the list).

Best regards
Patrick

[1]
https://github.com/spacewalkproject/spacewalk/commit/5923c05266b8ecdc165c1e14f2b2e62a9acc1295
[2] https://github.com/spacewalkproject/spacewalk/pull/497
[3]
https://patch-diff.githubusercontent.com/raw/spacewalkproject/spacewalk/pull/497.patch

--
Lobster SCM GmbH, Hindenburgstraße 15, D-82343 Pöcking
HRB 178831, Amtsgericht München
Geschäftsführer: Dr. Martin Fischer, Rolf Henrich