[Thincrust-devel] [patch] act md5/sha256 disk signature support for appliance-creator

[Joey Boggs]

one more quick edit to remove some debug printouts

Joey Boggs wrote:
> I figured it out. The hashlib.$methods()   had diskpath inbetween the ()
>
> new patch attached
>
>
>
> Joey Boggs wrote:
>> Think you found a bug :)
>>
>>
>>
>> Joey Boggs wrote:
>>> Bryan Kearney wrote:
>>>> Joey Boggs wrote:
>>>>> Adds md5/sha256 disk signature support for appliance-creator 
>>>>> enabled by --checksum option
>>>>>
>>>>> Still awaiting approval and commit for python-virtinst for 
>>>>> virt-image import verification portions.
>>>>
>>>
>>>
>>> you'll have to run md5sum and sha256sum in binary mode add the -b 
>>> option and they will match.
>>>
>>> Both formats were added to ensure a higher level of verifications 
>>> where available (sha256) using hashlib which is only in python 2.5. 
>>> More details on et-mgmt-tools list.
>>>
>>>>
>>>> Is the chunking causing issues? I patched and ran the file, I get 
>>>> this in the xml:
>>>>
>>>> [root at localhost resources]# cat git.xml | grep checksum
>>>>    <checksum type="md5">061a2a9f757acb0035bc3b01ad8756ef</checksum>
>>>>    <checksum 
>>>> type="sha256">5b0ab929b233e7b1464c112ee265884a49ed8124711b6fdee4cd449d3f69fc71</checksum> 
>>>>
>>>> [root at localhost resources]#
>>>>
>>>>
>>>> Verifying from the command line, I get this:
>>>>
>>>> [bkearney at localhost resources]$ md5sum git-sda.raw
>>>> b57f316acd9c6859bfc52bcfa2ef9ffa  git-sda.raw
>>>> [bkearney at localhost resources]$ sha256sum git-sda.raw
>>>> 9d79dc14e0e3d2d797ed118b96948226f056c8bf0ff4ac758f40b672ad14bfee 
>>>> git-sda.raw
>>>> [bkearney at localhost resources]$
>>>>
>>>>
>>>> They do not match. Also.. I am sure you covered this earlier.. why 
>>>> do both?
>>>>
>>>> -- bk
>>>>
>>>>
>>>> _______________________________________________
>>>> Thincrust-devel mailing list
>>>> Thincrust-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/thincrust-devel
>>>
>>> _______________________________________________
>>> Thincrust-devel mailing list
>>> Thincrust-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/thincrust-devel
>>
>> _______________________________________________
>> Thincrust-devel mailing list
>> Thincrust-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/thincrust-devel
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Thincrust-devel mailing list
> Thincrust-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/thincrust-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: act-disksignature-10231103.patch
Type: text/x-patch
Size: 3721 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/thincrust-devel/attachments/20081003/a07f0183/attachment.bin>