[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [patch] TUX 2.4.8-B2



A bug has crept in during your clean up of my patch. Patch is attached.
You made generation of ETag's conditional which should not be done. The
condition was set so that ETag's were only generated if somebody sent an
If-None-Match headerfield which will never happen on an initial request or
when the client has nothing cached.

As both ETag-field and Length-field (Generated as part of ETag) are
required to output headers in proto_http.c Tux didn't work.

After removing the condition I haven't noticed any problems yet.

Dirk Moerenhout ///// System Administrator ///// Planet Internet NV

On Thu, 23 Aug 2001, Ingo Molnar wrote:

>
> The latest TUX patch, 2.4.8-B2 (against vanilla 2.4.8, or against
> 2.4.8-ac9) can be downloaded from:
>
>   http://redhat.com/~mingo/TUX-patches/tux2-full-2.4.8-B2.bz2
>   http://redhat.com/~mingo/TUX-patches/tux2-full-2.4.8-ac9-B2.bz2
>
> -B2 includes the Etag support feature from Dirk Moerenhout.
>
> as always, bugreports, fixes, comments, suggestions welcome.
>
> 	Ingo
>
>
>
> _______________________________________________
> tux-list mailing list
> tux-list@redhat.com
> https://listman.redhat.com/mailman/listinfo/tux-list
>

--- linux-2.4.8-ac9-tux-B2-prev/net/tux/input.c	Thu Aug 23 13:07:36 2001
+++ linux-2.4.8-ac9-tux-B2/net/tux/input.c	Thu Aug 23 12:35:24 2001
@@ -210,7 +210,7 @@
 	req->filelen = inode->i_size;
 	req->mtime = inode->i_mtime;
 
-	if (req->if_none_match_len) {
+	{
 
 		unsigned int num = req->filelen;
 		int nr_digits = 0;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index] []