[virt-tools-list] [PATCH] virtinst : fix virtmanager qemu commandline at new vm (format=<empty string>)

Alban Browaeys prahal at yahoo.com
Thu Jul 30 15:47:22 UTC 2009


The code was querying format tag content instead of its type attribute.

 Here is a fix.

diff -r 2ca5493b648a virtinst/VirtualDisk.py
--- a/virtinst/VirtualDisk.py   Tue Jul 28 22:17:24 2009 -0400
+++ b/virtinst/VirtualDisk.py   Thu Jul 30 17:43:28 2009 +0200
@@ -470,7 +470,7 @@

         if self.vol_object:
             drvtype = _util.get_xml_path(self.vol_object.XMLDesc(0),
-                                         "/volume/target/format")
+                                         "/volume/target/format/@type")

         elif self.vol_install:
             if drvname == self.DRIVER_QEMU:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virtinst_fixvoltypequery_forvirtmanagerwizardusingexistingstorage_fixfailureduetoqemuformatargbehingemptystring.diff
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20090730/ec871e42/attachment.bin>


More information about the virt-tools-list mailing list