[virt-tools-list] [Patch V2] Add virDomainSetMigrateMaxDowntime support

[Cole Robinson]

On 11/23/2010 10:40 PM, Wen Congyang wrote:
> # HG changeset patch
> # User Wen Congyang <wency at cn.fujitsu.com>
> # Date 1290569680 -28800
> # Node ID 519e30777e538476c18a329984b44d37d27c39c9
> # Parent  076759c3ada6fbb26c32d9181fb381097ed6bd0c
> Add virDomainSetMigrateMaxDowntime support
> 

Thanks, I've pushed this now:

http://hg.fedorahosted.org/hg/virt-manager/rev/f2d5683fb5ed


> diff -r 076759c3ada6 -r 519e30777e53 src/virtManager/domain.py
> --- a/src/virtManager/domain.py	Tue Nov 23 20:13:50 2010 -0500
> +++ b/src/virtManager/domain.py	Wed Nov 24 11:34:40 2010 +0800
> @@ -944,6 +944,12 @@
>      def _XMLDesc(self, flags):
>          return self._backend.XMLDesc(flags)
>  
> +    def support_downtime(self):
> +        # Note: this function has side effect
> +        # if domain supports downtime, the downtime may be overriden to 30ms
> +        return support.check_domain_support(self._backend,
> +                        support.SUPPORT_DOMAIN_MIGRATE_DOWNTIME)
> +

Hmm, I didn't think of that. I've pushed a change to virtinst now that
should practically eliminate the likelihood of side effects:

http://hg.fedorahosted.org/hg/python-virtinst/rev/df54d069af85

I'd be interested in a follow up patch to clean up these comments, and
use the support check earlier in the migrate dialog.

Thanks,
Cole