[virt-tools-list] libguestfs on OSX

[Richard W.M. Jones]

On Fri, Oct 22, 2010 at 01:44:23PM -0600, Eric Blake wrote:
> On 10/22/2010 01:06 PM, Richard W.M. Jones wrote:
> >On Sat, Oct 23, 2010 at 05:44:54AM +1100, Justin Clift wrote:
> >>****************************************************
> >>#define    ENOKEY        126
> >>****************************************************
> >
> >This isn't going to be much help unfortunately.  We need a standard
> >errno which will be available to users and is distinct from any other
> >value we could possibly return.  Difficult one ...
> 
> Gnulib has already solved the problem of how to portably add errno
> values missing on various systems; it's just that ENOKEY is not a
> POSIX-mandated errno value.  Is there any other standard that
> describes its existence, which would justify adding it to gnulib's
> errno.h in spite of not being in POSIX; or should we be guarding
> code with #ifdef ENOKEY?

The problem is that the hivex API returns ENOKEY for certain error
conditions.  Naturally I didn't think to check POSIX before doing this ...

> >  695     case hive_t_qword: {
> >  696       int64_t j = hivex_value_qword (h, value);
> >  697       printf ("%" PRIi64 "\n", j);
> 
> Indeed.  And the fact that the compiler is complaining about
> gl_int64_t makes it sound like gnulib is implicated.  Would you mind
> reducing this to a simpler testcase and posting to bug-gnulib AT
> gnu.org?

I'll have a go.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v