[virt-tools-list] [PATCH] Add operating system icon in the Details->Overview pane.

[Daniel P. Berrange]

On Wed, Apr 20, 2011 at 11:55:28AM +0100, Daniel P. Berrange wrote:
> On Tue, Apr 19, 2011 at 04:50:28PM +0100, Richard W.M. Jones wrote:
> > 
> > This adds an icon to each Operating System section in the
> > Details->Overview pane.  If inspection completes while a guest's
> > Details window is open, then the icon updates itself(!)
> > 
> > Screenshots:
> > 
> > http://oirase.annexia.org/tmp/vmm-with-logo.png
> > http://oirase.annexia.org/tmp/vmm-with-logo-2.png
> > 
> > The icons are taken from either Wikipedia or the upstream project and
> > resized to 32 px width by myself.  You may be wondering about the
> > legality of including these trademarked icons in Fedora packages, and
> > I was too.  I asked Fedora Legal for a verdict with no reply yet:
> > 
> > http://lists.fedoraproject.org/pipermail/legal/2011-April/001604.html
> 
> It seems pretty discouraging
> 
>   "The complete answer here is not simple, but I can give you a simple one:
> 
>    * Don't do it. It would not be acceptable for Fedora. Use the word marks
>      instead.
> 
>    Let me know if that is not sufficient and you want the more complete answer."
> 
> 
> Could we side-step the entire issue, by actually using libguestfs to
> extract an icon file from the guest OS image. Most OS installs include
> some kind of theme with icons/graphics in their default install set.
> It won't work 100% of the time, but perhaps it'd work often enough to
> be viable.

As an example, Fedora includes  /etc/favicon.png  which is apparently
intended to be an admin customization point[1]. It'd be kinda neat to pull
this out & display it, so virt-manager shows whatever the guest admin
has assigned for that guest.

Daniel

[1] http://cgwalters.livejournal.com/19030.html
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|